Minor fix in impersonation test case #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nineinchnick
reviewed
Oct 5, 2025
Contributor
Author
|
@nineinchnick can you review this please? Seems like there might have been a typo originally. |
nineinchnick
approved these changes
Oct 28, 2025
Member
|
This fix looks correct, but the test was passing anyway, so it seems it's not testing what it's supposed to. |
Member
|
Please squash commits and remove the |
laserninja
force-pushed
the
minor-test-case-fix
branch
from
916ae63 to
637ef48
Compare
laserninja
force-pushed
the
minor-test-case-fix
branch
from
637ef48 to
e128131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separating out a failing test case in #309