From f1755088c0e2da873bb466b9711a5e7ac9a02f0d Mon Sep 17 00:00:00 2001
From: Mykola Stasiuk <93274808+st-myk@users.noreply.github.com>
Date: Sun, 13 Jul 2025 13:05:39 +0200
Subject: [PATCH] Add resource related comments

Had some problems launching the app with requests and limits set. Wanted to share some reasonable defaults with the community.
---
 charts/trino/values.yaml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/charts/trino/values.yaml b/charts/trino/values.yaml
index 4733c8b9..c20ad1f9 100644
--- a/charts/trino/values.yaml
+++ b/charts/trino/values.yaml
@@ -59,6 +59,7 @@ server:
     # PASSWORD, CERTIFICATE, OAUTH2, JWT, KERBEROS.
     authenticationType: ""
     query:
+      # -- Should be the same or slightly less than worker.resources memory values if set
       maxMemory: "4GB"
   exchangeManager: {}
   # server.exchangeManager -- Mandatory [exchange manager
@@ -569,14 +570,17 @@ coordinator:
     # coordinator.deployment.strategy -- The deployment strategy to use to replace existing pods with new ones.
 
   jvm:
+    # -- Should be around 70% of coordinator.resources memory values if set
     maxHeapSize: "8G"
     gcMethod:
       type: "UseG1GC"
       g1:
+        # -- Should be around 10% of coordinator.resources memory values if set
         heapRegionSize: "32M"
 
   config:
     memory:
+      # -- Should be around 30% of coordinator.resources memory values if set
       heapHeadroomPerNode: ""
     nodeScheduler:
       includeCoordinator: false
@@ -585,6 +589,7 @@ coordinator:
       # coordinator can negatively impact query performance because the machine's resources are not available for the
       # critical coordinator tasks of scheduling, managing, and monitoring query execution.
     query:
+      # -- Should be around 20% of coordinator.resources memory values if set
       maxMemoryPerNode: "1GB"
 
   additionalJVMConfig: []
@@ -754,16 +759,20 @@ worker:
     # worker.deployment.strategy -- The deployment strategy to use to replace existing pods with new ones.
 
   jvm:
+    # -- Should be around 70% of worker.resources memory values if set
     maxHeapSize: "8G"
     gcMethod:
       type: "UseG1GC"
       g1:
+        # -- Should be around 10% of worker.resources memory values if set
         heapRegionSize: "32M"
 
   config:
     memory:
+      # -- Should be around 30% of worker.resources memory values if set
       heapHeadroomPerNode: ""
     query:
+      # -- Should be around 20% of worker.resources memory values if set
       maxMemoryPerNode: "1GB"
 
   additionalJVMConfig: []