TriggerMesh components dev version support removed (#309)

Author: tzununbekov

pkg/load/load.go

@@ -35,6 +35,7 @@ import (
 	"github.com/triggermesh/tmctl/pkg/triggermesh/crd"
 )
 
+// Import creates the integration from provided YAML manifest.
 func Import(from string, config *cliconfig.Config, crd map[string]crd.CRD) error {
 	m, err := getManifest(from)
 	if err != nil {

pkg/triggermesh/crd/crd.go

@@ -17,13 +17,11 @@ limitations under the License.
 package crd
 
 import (
-	"encoding/json"
 	"fmt"
 	"io"
 	"net/http"
 	"os"
 	"path/filepath"
-	"regexp"
 	"sort"
 	"strings"
 
@@ -32,31 +30,9 @@ import (
 	"github.com/triggermesh/tmctl/pkg/log"
 )
 
-const (
-	crdsURL         = "https://github.com/triggermesh/triggermesh/releases/download/$VERSION/triggermesh-crds.yaml"
-	commitStatusURL = "https://api.github.com/repos/triggermesh/triggermesh/commits/$REF/status"
-	ciArtifactsURL  = "https://circleci.com/api/v2/project/gh/triggermesh/triggermesh/$JOB/artifacts"
-
-	ciBuildImageContext = "ci/circleci: publish-image"
-)
-
-var semverRegexp = regexp.MustCompile(`^v(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$`)
-
-type ghJobStatus struct {
-	SHA      string `json:"sha"`
-	Statuses []struct {
-		State     string `json:"state"`
-		TargetURL string `json:"target_url"`
-		Context   string `json:"context"`
-	} `json:"statuses"`
-}
-
-type ciArtifacts struct {
-	Items []struct {
-		URL string `json:"url"`
-	} `json:"items"`
-}
+const crdsURL = "https://github.com/triggermesh/triggermesh/releases/download/$VERSION/triggermesh-crds.yaml"
 
+// CRD represents the custom resource definition for CLI functions.
 type CRD struct {
 	APIVersion string `yaml:"apiVersion"`
 	Kind       string `yaml:"kind"`
@@ -121,15 +97,9 @@ func Fetch(configDir, version string) (map[string]CRD, error) {
 	}
 	defer out.Close()
 
-	var resp *http.Response
-	if release := semverRegexp.MatchString(version); release {
-		if resp, err = http.Get(strings.ReplaceAll(crdsURL, "$VERSION", version)); err != nil {
-			return nil, err
-		}
-	} else {
-		if resp, err = getBuildArtifact(version); err != nil {
-			return nil, fmt.Errorf("%q build: %w", version, err)
-		}
+	resp, err := http.Get(strings.ReplaceAll(crdsURL, "$VERSION", version))
+	if err != nil {
+		return nil, err
 	}
 	defer resp.Body.Close()
 
@@ -148,6 +118,7 @@ func Fetch(configDir, version string) (map[string]CRD, error) {
 	return Parse(f)
 }
 
+// Parse reads the CRD file contents into the map.
 func Parse(reader io.ReadCloser) (map[string]CRD, error) {
 	var crds []CRD
 	decoder := yaml.NewDecoder(reader)
@@ -203,52 +174,3 @@ func ListTargets(crds map[string]CRD) ([]string, error) {
 	sort.Strings(result)
 	return result, nil
 }
-
-func getBuildArtifact(ref string) (*http.Response, error) {
-	ghCommit, err := http.Get(strings.Replace(commitStatusURL, "$REF", ref, -1))
-	if err != nil {
-		return nil, err
-	}
-	defer ghCommit.Body.Close()
-
-	var ghJob ghJobStatus
-	if err := json.NewDecoder(ghCommit.Body).Decode(&ghJob); err != nil {
-		return nil, err
-	}
-	ciJobID := ""
-	for _, status := range ghJob.Statuses {
-		if status.Context == ciBuildImageContext {
-			if status.State != "success" {
-				return nil, fmt.Errorf("dev build is not ready")
-			}
-			path := strings.Split(status.TargetURL, "/")
-			ciJobID = path[len(path)-1]
-			break
-		}
-	}
-	if ciJobID == "" {
-		return nil, fmt.Errorf("CI build job not found")
-	}
-
-	ciBuild, err := http.Get(strings.Replace(ciArtifactsURL, "$JOB", ciJobID, -1))
-	if err != nil {
-		return nil, err
-	}
-	defer ciBuild.Body.Close()
-
-	var artifacts ciArtifacts
-	if err := json.NewDecoder(ciBuild.Body).Decode(&artifacts); err != nil {
-		return nil, err
-	}
-	crdURL := ""
-	for _, artifact := range artifacts.Items {
-		if strings.HasSuffix(artifact.URL, "/triggermesh-crds.yaml") {
-			crdURL = artifact.URL
-			break
-		}
-	}
-	if crdURL == "" {
-		return nil, fmt.Errorf("CRD artifact not found")
-	}
-	return http.Get(crdURL)
-}