Merge pull request #12 from triggermesh/task/add-awss3source

Add S3 Source

Author: Pablo Mercado

cmd/triggermesh-hook/start/start.go

@@ -7,6 +7,8 @@ import (
 	commoncmd "github.com/triggermesh/scoby-hook-triggermesh/pkg/common/cmd"
 	"github.com/triggermesh/scoby-hook-triggermesh/pkg/handler"
 	"github.com/triggermesh/scoby-hook-triggermesh/pkg/handler/kuards"
+	"github.com/triggermesh/scoby-hook-triggermesh/pkg/sources/client/s3"
+	"github.com/triggermesh/scoby-hook-triggermesh/pkg/sources/reconciler/awss3source"
 
 	"github.com/triggermesh/scoby-hook-triggermesh/pkg/server"
 )
@@ -22,6 +24,7 @@ func (c *Cmd) Run(g *commoncmd.Globals) error {
 	r := handler.NewRegistry([]handler.Handler{
 		// Kuards is a temporary playground
 		kuards.New(),
+		awss3source.New(s3.NewClientGetter(g.KubeClient.CoreV1().Secrets), g.Logger),
 	})
 
 	s := server.New(c.Path, c.Address, r, g.DynClient, g.Logger)

config/200-clusterroles.yaml

@@ -1,60 +1,20 @@
-kind: ClusterRole
+# Use this aggregated ClusterRole to grant to
+# Scoby Hook for Triggermesh premissions on
+# registered objects.
 apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
 metadata:
+  # There might be an addressable-resolver ClusterRole if Knative Eventing is installed.
+  # This would be a duplicate for TriggerMesh's scoby that would add support for scenarios
+  # where Knative Eventing is not installed but Knative Serving is.
   name: scoby-hook-triggermesh
   labels:
-    scoby.triggermesh.io/crdregistration: "true"
-    app.kubernetes.io/name: scoby
-rules:
-- apiGroups:
-  - "extensions.triggermesh.io"
-  resources:
-  - kuards
-  verbs:
-  - get
-  - list
-  - watch
-
----
-
-# ClusterRole that will be aggregated at Scoby so that it can
-# manage these objects.
+    eventing.knative.dev/release: devel
+    app.kubernetes.io/version: devel
+    app.kubernetes.io/name: scoby-hook-triggermesh
+aggregationRule:
+  clusterRoleSelectors:
+  - matchLabels:
+      scoby.triggermesh.io/scoby-hook-triggermesh: "true"
+rules: [] # Rules are automatically filled in by the controller manager.
 
-kind: ClusterRole
-apiVersion: rbac.authorization.k8s.io/v1
-metadata:
-  name: crd-registrations-scoby-kuard
-  labels:
-    scoby.triggermesh.io/crdregistration: "true"
-    app.kubernetes.io/name: scoby
-# Do not use this role directly. These rules will be added to the "crd-registrations-scoby" role.
-rules:
-- apiGroups:
-  - "extensions.triggermesh.io"
-  resources:
-  - kuards
-  verbs:
-  - get
-  - list
-  - watch
-  - update
-- apiGroups:
-  - "extensions.triggermesh.io"
-  resources:
-  - kuards/status
-  verbs:
-  - get
-  - update
-  - patch
-  # If a hook is used for finalization, the finalize resource
-  # must be added to the ClusterRole.
-- apiGroups:
-  - "extensions.triggermesh.io"
-  resources:
-  - kuards/finalizers
-  verbs:
-  - list
-  - watch
-  - create
-  - update
-  - delete

config/300-awss3source-clusterrole.yaml

@@ -0,0 +1,54 @@
+
+kind: ClusterRole
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: scoby-hook-awss3sources
+  labels:
+    # Do not use this role directly.
+    # These rules will be added to the "scoby-hook-triggermesh" role.
+    scoby.triggermesh.io/scoby-hook-triggermesh: "true"
+    app.kubernetes.io/name: scoby-hook-triggermesh
+rules:
+- apiGroups:
+  - sources.triggermesh.io
+  resources:
+  - awss3sources
+  verbs:
+  - get
+
+---
+
+kind: ClusterRole
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: scoby-awss3sources
+  labels:
+    # Do not use this role directly. These rules will be added to the "crd-registrations-scoby" role.
+    scoby.triggermesh.io/crdregistration: "true"
+    app.kubernetes.io/name: scoby
+rules:
+- apiGroups:
+  - sources.triggermesh.io
+  resources:
+  - awss3sources
+  verbs:
+  - get
+  - list
+  - watch
+  - update
+- apiGroups:
+  - sources.triggermesh.io
+  resources:
+  - awss3sources/status
+  verbs:
+  - get
+  - update
+  - patch
+  # If a hook is used for finalization, the finalize resource
+  # must be added to the ClusterRole.
+- apiGroups:
+  - sources.triggermesh.io
+  resources:
+  - awss3sources/finalizers
+  verbs:
+  - update