fix: needsPromotion fixed in deploy github actions (#1741)

ericallam · web-flow · commit e0241819a401 · 2025-03-01T10:29:44.000Z
diff --git a/.changeset/silent-squids-glow.md b/.changeset/silent-squids-glow.md
@@ -0,0 +1,5 @@
+---
+"trigger.dev": patch
+---
+
+Fixes needsPromotion github action output
diff --git a/packages/cli-v3/src/commands/deploy.ts b/packages/cli-v3/src/commands/deploy.ts
@@ -501,7 +501,7 @@ async function _deployCommand(dir: string, options: DeployCommandOptions) {
       testUrl: `${authorization.dashboardUrl}/projects/v3/${
         resolvedConfig.project
       }/test?environment=${options.env === "prod" ? "prod" : "stg"}`,
-      needsPromotion: options.skipPromotion ? "false" : "true",
+      needsPromotion: options.skipPromotion ? "true" : "false",
     },
   });
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"trigger.dev": patch
 +---
++
 +Fixes needsPromotion github action output
Original file line number	Diff line number	Diff line change
`@@ -501,7 +501,7 @@ async function _deployCommand(dir: string, options: DeployCommandOptions) {`
`501`	`501`	testUrl: `${authorization.dashboardUrl}/projects/v3/${
`502`	`502`	`resolvedConfig.project`
`503`	`503`	}/test?environment=${options.env === "prod" ? "prod" : "stg"}`,
`504`		`- needsPromotion: options.skipPromotion ? "false" : "true",`
	`504`	`+ needsPromotion: options.skipPromotion ? "true" : "false",`
`505`	`505`	`},`
`506`	`506`	`});`
`507`	`507`	`}`