Fix for detecting internal errors

Author: matt-aitken

packages/core/src/v3/errors.ts

@@ -31,7 +31,7 @@ export class InternalError extends Error {
     skipRetrying?: boolean;
   }) {
     super(`${code}: ${message ?? "No message"}`);
-    this.name = "InternalError";
+    this.name = "TriggerInternalError";
     this.code = code;
     this.message = message ?? "InternalError";
 
@@ -43,6 +43,10 @@ export class InternalError extends Error {
   }
 }
 
+export function isInternalError(error: unknown): error is InternalError {
+  return error instanceof Error && error.name === "TriggerInternalError";
+}
+
 export class AbortTaskRunError extends Error {
   constructor(message: string) {
     super(message);
@@ -63,7 +67,7 @@ export class TaskPayloadParsedError extends Error {
 }
 
 export function parseError(error: unknown): TaskRunError {
-  if (error instanceof InternalError) {
+  if (isInternalError(error)) {
     return {
       type: "INTERNAL_ERROR",
       code: error.code,

packages/core/src/v3/workers/taskExecutor.ts

@@ -2,7 +2,13 @@ import { SpanKind } from "@opentelemetry/api";
 import { VERSION } from "../../version.js";
 import { ApiError, RateLimitError } from "../apiClient/errors.js";
 import { ConsoleInterceptor } from "../consoleInterceptor.js";
-import { InternalError, parseError, sanitizeError, TaskPayloadParsedError } from "../errors.js";
+import {
+  InternalError,
+  isInternalError,
+  parseError,
+  sanitizeError,
+  TaskPayloadParsedError,
+} from "../errors.js";
 import { runMetadata, TriggerConfig, waitUntil } from "../index.js";
 import { recordSpanException, TracingSDK } from "../otel/index.js";
 import {
@@ -536,11 +542,13 @@ export class TaskExecutor {
 
     if (
       error instanceof Error &&
-      (error.name === "AbortTaskRunError" ||
-        error.name === "TaskPayloadParsedError" ||
-        ("skipRetrying" in error && error.skipRetrying === true))
+      (error.name === "AbortTaskRunError" || error.name === "TaskPayloadParsedError")
     ) {
-      return { status: "skipped", error: error instanceof InternalError ? error : undefined };
+      return { status: "skipped" };
+    }
+
+    if (isInternalError(error) && error.skipRetrying) {
+      return { status: "skipped", error };
     }
 
     if (execution.run.maxAttempts) {