Test gz api with miri
#431
Merged
+19
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
folkertdev
force-pushed
the
miri-gz
branch
3 times, most recently
from
1c60715 to
9438e98
Compare
The C source assumes that when a write succeeds it writes all bytes. that is not strictly required, but effectively true in most cases where zlib is used. However, miri does not respect this. So when running miri, explicitly loop until all bytes are written
bjorn3
reviewed
Dec 1, 2025
libz-rs-sys-cdylib/src/gz.rs
Outdated
|
|
||
| /// Deal with miri often not writing the full buffer in one go. That is valid, but zlib assumes | ||
| /// that writes are to true files and succeed unless e.g. the disk is full. | ||
| #[cfg(miri)] |
Collaborator
There was a problem hiding this comment.
You can disable this behavior using -Zmiri-no-short-fd-operations.
bjorn3
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.