Add tests for Link class

Author: acoburn

build.gradle

@@ -33,11 +33,13 @@ ext {
     camelVersion = '2.19.3'
 
     /* Testing */
-    junitVersion = '4.12'
+    junitVersion = '5.0.1'
+    junitPlatformVersion = '1.0.1'
     jaxbVersion = '2.3.0'
     jacocoVersion = '0.7.9'
     activationVersion = '1.1.1'
     logbackVersion = '1.2.3'
+    apiguardianVersion = '1.0.0'
 
     /* OSGi */
     projectOsgiVersion = project.version.replaceAll("-SNAPSHOT", ".SNAPSHOT")
@@ -57,7 +59,9 @@ jacocoTestReport {
 dependencies {
     api group: 'org.apache.camel', name: 'camel-core', version: camelVersion
 
-    testImplementation group: 'junit', name: 'junit', version: junitVersion
+    testImplementation group: 'org.apiguardian', name: 'apiguardian-api', version: apiguardianVersion
+    testImplementation group: 'org.junit.platform', name: 'junit-platform-runner', version: junitPlatformVersion
+    testImplementation group: 'org.junit.jupiter', name: 'junit-jupiter-engine', version: junitVersion
     testImplementation group: 'org.apache.camel', name: 'camel-test', version: camelVersion
     testImplementation group: 'javax.xml.bind', name: 'jaxb-api', version: jaxbVersion
     testImplementation group: 'ch.qos.logback', name: 'logback-classic', version: logbackVersion

src/main/java/org/trellisldp/camel/Link.java

@@ -33,19 +33,19 @@ public class Link {
      */
     public Link(final String value) {
         final String[] parts = value.split(";");
-        if (parts.length >= 1) {
-            final String val = parts[0].trim();
-            this.uri = val.startsWith("<") && val.endsWith(">") ? val.substring(1, val.length() - 1) : null;
-            for (int i = 1; i < parts.length; i++) {
-                final String[] p = parts[1].trim().split("=");
-                if (p.length == 2) {
-                    if (!params.containsKey(p[0])) {
+        final String val = parts[0].trim();
+        this.uri = val.startsWith("<") && val.endsWith(">") ? val.substring(1, val.length() - 1) : null;
+        for (int i = 1; i < parts.length; i++) {
+            final String[] p = parts[i].trim().split("=");
+            if (p.length == 2) {
+                if (!params.containsKey(p[0])) {
+                    if (p[1].startsWith("\"") && p[1].endsWith("\"")) {
+                        params.put(p[0], p[1].substring(1, p[1].length() - 1));
+                    } else {
                         params.put(p[0], p[1]);
                     }
                 }
             }
-        } else {
-            this.uri = null;
         }
     }
 

src/test/java/org/trellisldp/camel/LinkTest.java

@@ -0,0 +1,84 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.trellisldp.camel;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+import org.junit.jupiter.api.Test;
+import org.junit.platform.runner.JUnitPlatform;
+import org.junit.runner.RunWith;
+
+/**
+ * @author acoburn
+ */
+@RunWith(JUnitPlatform.class)
+public class LinkTest {
+
+    @Test
+    public void testLinkWithParams() {
+        final Link link = new Link("<http://www.w3.org/ns/ldp#Container>; rel=\"type\";" +
+                "title=\"some title\"; type=\"text/turtle\"; other=\"param\"");
+        assertEquals("http://www.w3.org/ns/ldp#Container", link.getUri());
+        assertEquals("type", link.getRel());
+        assertEquals("some title", link.getTitle());
+        assertEquals("text/turtle", link.getType());
+        assertEquals("param", link.getParams().get("other"));
+        assertEquals(4L, link.getParams().size());
+    }
+
+    @Test
+    public void testLinkRelQuotes() {
+        final Link link = new Link("<http://www.w3.org/ns/ldp#Container>; rel=\"type\"");
+        assertEquals("http://www.w3.org/ns/ldp#Container", link.getUri());
+        assertEquals("type", link.getRel());
+        assertNull(link.getTitle());
+        assertNull(link.getType());
+        assertEquals(1L, link.getParams().size());
+    }
+
+    @Test
+    public void testLinkRelNoQuotes() {
+        final Link link = new Link("<http://www.w3.org/ns/ldp#Container>;rel=type");
+        assertEquals("http://www.w3.org/ns/ldp#Container", link.getUri());
+        assertEquals("type", link.getRel());
+        assertNull(link.getTitle());
+        assertNull(link.getType());
+        assertEquals(1L, link.getParams().size());
+    }
+
+    @Test
+    public void testNoURI() {
+        final Link link = new Link("");
+        assertNull(link.getUri());
+    }
+
+    @Test
+    public void testBadURI() {
+        final Link link = new Link("<blah");
+        assertNull(link.getUri());
+    }
+
+    @Test
+    public void testBadParam() {
+        final Link link = new Link("<uri>; rel");
+        assertNull(link.getRel());
+    }
+
+    @Test
+    public void testMultipleParams() {
+        final Link link = new Link("<uri>; rel=one; rel=two; rel=three");
+        assertEquals("one", link.getRel());
+    }
+}