Merge pull request #91 from travis-ci/sentry_cleanup_am

[BSFY-168/169] Handle missing payload fields

Author: murtaza-swati

lib/travis/listener/app.rb

@@ -111,6 +111,10 @@ def dispatch_event
 
         return unless handle_event?
 
+        # According to GitHub every webhook payload should have this
+        # If it is not present, assume payload is malformed
+        return unless payload['sender']
+
         debug "Event payload for #{uuid}: #{payload.inspect}"
 
         log_event

lib/travis/listener/schemas.rb

@@ -144,37 +144,37 @@ def self.event_details(event_type, payload)
             source:       payload['pull_request']['head']['repo'] && payload['pull_request']['head']['repo']['full_name'],
             head:         payload['pull_request']['head']['sha'][0..6],
             ref:          payload['pull_request']['head']['ref'],
-            user:         payload['pull_request']['head']['user']['login'],
-            sender:       payload['sender']['login'],
-            sender_type:  payload['sender']['type']
+            user:         payload['pull_request']['head'].fetch('user', {}).fetch('login', ''),
+            sender:       payload['sender'].fetch('login', ''),
+            sender_type:  payload['sender'].fetch('type', '')
           }
         when 'push'
           {
             repository:   payload["repository"]["full_name"],
             ref:          payload['ref'],
             head:         payload['head_commit'] && payload['head_commit']['id'][0..6],
             commits:      (payload["commits"] || []).map {|c| c['id'][0..6]}.join(","),
-            sender:       payload['sender']['login'],
-            sender_type:  payload['sender']['type']
+            sender:       payload['sender'].fetch('login', ''),
+            sender_type:  payload['sender'].fetch('type', '')
           }
         when 'check_suite'
           {
             action:     payload['action'],
             ref_type:   payload['check_suite']['ref_type'],
             repository: payload["repository"]["full_name"],
-            sender:     payload['sender']['login']
+            sender:     payload['sender'].fetch('login', '')
           }
         when 'create', 'delete', 'repository', 'check_run'
           {
             action:     payload['action'],
             repository: payload["repository"]["full_name"],
-            sender:     payload['sender']['login']
+            sender:     payload['sender'].fetch('login', '')
           }
         when 'installation', 'installation_repositories'
           {
             action:       payload['action'],
             installation: payload["installation"]["account"]["login"],
-            sender:       payload['sender']['login']
+            sender:       payload['sender'].fetch('login', '')
           }
         else
           { }