[TBT-392] Soft delete orgs and repo (#1399)

* [TBT-392] Soft delete orgs and repo

* removed pry

* Added logging

* Refactored code

* Fixed specs

* Fixed organization spec

* Stub spec URL

* Restore Repo and orgs

* Stub request

* Stub request

* Used restrict instead of destroy

* revert admin ID

* fixed specs

* use hash string

* Added default scope deleted_at

* fixed specs

---------

Co-authored-by: Dominik <dominik.alberski@gmail.com>

Author: mshahzaib-travis

lib/travis/api/app/endpoint/assembla.rb

@@ -4,6 +4,8 @@
 require 'travis/remote_vcs/repository'
 require 'travis/api/v3/billing_client'
 require 'travis/services/assembla_user_service'
+require 'travis/services/assembla_notify_service'
+require 'travis/remote_vcs/client'
 require_relative '../jwt_utils'
 
 class Travis::Api::App
@@ -13,6 +15,7 @@ class Assembla < Endpoint
       include Travis::Api::App::JWTUtils
 
       REQUIRED_JWT_FIELDS = %w[name email login space_id repository_id id refresh_token].freeze
+      REQUIRED_NOTIFY_FIELDS = %w[action object id].freeze
       CLUSTER_HEADER = 'HTTP_X_ASSEMBLA_CLUSTER'.freeze
 
       set prefix: '/assembla'
@@ -39,6 +42,19 @@ class Assembla < Endpoint
         }
       end
 
+      post '/notify' do
+        service = Travis::Services::AssemblaNotifyService.new(@jwt_payload)
+        if service.run
+          {
+            status: 200,
+            body: { message: 'Assembla notification processed successfully' }
+          }
+        else
+          Travis.logger.error("Failed to process Assembla notification")
+          halt 500, { error: 'Failed to process notification' }
+        end
+      end
+
       private
 
       def validate_request!
@@ -49,7 +65,8 @@ def validate_request!
       end
 
       def check_required_fields
-        missing = REQUIRED_JWT_FIELDS.select { |f| @jwt_payload[f].nil? || @jwt_payload[f].to_s.strip.empty? }
+        required_fields = request.path_info.end_with?('/notify') ? REQUIRED_NOTIFY_FIELDS : REQUIRED_JWT_FIELDS
+        missing = required_fields.select { |f| @jwt_payload[f].nil? || @jwt_payload[f].to_s.strip.empty? }
         unless missing.empty?
           halt 400, { error: 'Missing required fields', missing: missing }
         end

lib/travis/api/v3/models/organization.rb

@@ -2,6 +2,7 @@
 
 module Travis::API::V3
   class Models::Organization < Model
+    default_scope { where(deleted_at: nil) }
     has_many :memberships
     has_many :users, through: :memberships
     has_one  :beta_migration_request

lib/travis/api/v3/models/repository.rb

@@ -2,6 +2,7 @@
 
 module Travis::API::V3
   class Models::Repository < Model
+    default_scope { where(deleted_at: nil) }
     has_many :commits,     dependent: :delete_all
     has_many :requests,    dependent: :delete_all
     has_many :branches,    -> { order('branches.id DESC'.freeze) }, dependent: :delete_all

lib/travis/model/organization.rb

@@ -3,6 +3,8 @@
 
 class Organization < Travis::Model
   self.table_name = 'organizations'
+  default_scope { where(deleted_at: nil) }
+
   has_many :memberships
   has_many :users, :through => :memberships
   has_many :repositories, :as => :owner

lib/travis/model/repository.rb

@@ -12,6 +12,7 @@
 # hooks on Github.
 class Repository < Travis::Model
   self.table_name = 'repositories'
+  default_scope { where(deleted_at: nil) }
   include Travis::ScopeAccess
 
   require 'travis/model/repository/status_image'

lib/travis/remote_vcs/organization.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'travis/remote_vcs/client'
+
+module Travis
+  class RemoteVCS
+    class Organization < Client
+      def destroy(org_id:)
+        request(:delete, __method__, false) do |req|
+          req.url "organizations/#{org_id}"
+        end
+      rescue ResponseError => e
+        Travis.logger.error("Failed to destroy organization: #{e.message}")
+        false
+      end
+
+      def restore(org_id:)
+        request(:post, __method__, false) do |req|
+          req.url "organizations/#{org_id}/restore"
+        end
+      rescue ResponseError => e
+        Travis.logger.error("Failed to restore organization: #{e.message}")
+        false
+      end
+    end
+  end
+end

lib/travis/remote_vcs/repository.rb

@@ -73,6 +73,25 @@ def set_perforce_ticket(repository_id:, user_id:)
       rescue ResponseError
         {}
       end
+
+      def destroy(repository_id:, vcs_type:)
+        request(:delete, __method__, false) do |req|
+          req.url "repos/#{repository_id}"
+          req.params['vcs_type'] = vcs_type
+        end
+      rescue ResponseError => e
+        Travis.logger.error("Failed to destroy repository: #{e.message}")
+        false
+      end
+
+      def restore(repository_id:)
+        request(:post, __method__, false) do |req|
+          req.url "repos/#{repository_id}/restore"
+        end
+      rescue ResponseError => e
+        Travis.logger.error("Failed to restore repository: #{e.message}")
+        false
+      end
     end
   end
 end

lib/travis/services/assembla_notify_service.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+require 'travis/remote_vcs/repository'
+require 'travis/remote_vcs/organization'
+
+module Travis
+  module Services
+    class AssemblaNotifyService
+      VALID_ACTIONS = %w[restrict restore].freeze
+      VALID_OBJECTS = %w[space tool].freeze
+
+      def initialize(payload)
+        @action = payload['action']
+        @object = payload['object']
+        @object_id = payload['id']
+      end
+
+      def run
+        return false unless validate
+
+        case @object
+        when 'tool'
+          handle_tool_action
+        when 'space'
+          handle_space_action
+        else
+          false
+        end
+      end
+
+      private
+
+      def validate
+        unless VALID_ACTIONS.include?(@action)
+          Travis.logger.error("Invalid action: #{@action}. Allowed actions: #{VALID_ACTIONS.join(', ')}")
+          return false
+        end
+
+        unless VALID_OBJECTS.include?(@object)
+          Travis.logger.error("Invalid object type: #{@object}. Allowed objects: #{VALID_OBJECTS.join(', ')}")
+          return false
+        end
+
+        true
+      end
+
+      def handle_tool_action
+        vcs_repository = Travis::RemoteVCS::Repository.new
+        case @action
+        when 'restrict'
+          vcs_repository.destroy(repository_id: @object_id, vcs_type: 'AssemblaRepository')
+        when 'restore'
+          vcs_repository.restore(repository_id: @object_id)
+        end
+      end
+
+      def handle_space_action
+        vcs_organization = Travis::RemoteVCS::Organization.new
+        case @action
+        when 'restrict'
+          vcs_organization.destroy(org_id: @object_id)
+        when 'restore'
+          vcs_organization.restore(org_id: @object_id)
+        end
+      end
+    end
+  end
+end

spec/lib/services/assembla_notify_service_spec.rb

@@ -0,0 +1,87 @@
+require 'spec_helper'
+require 'travis/services/assembla_notify_service'
+
+RSpec.describe Travis::Services::AssemblaNotifyService do
+  let(:payload) { { 'action' => 'restrict', 'object' => 'tool', 'id' => '12345' } }
+  let(:service) { described_class.new(payload) }
+  let(:vcs_repository) { instance_double(Travis::RemoteVCS::Repository) }
+  let(:vcs_organization) { instance_double(Travis::RemoteVCS::Organization) }
+
+  before do
+    allow(Travis::RemoteVCS::Repository).to receive(:new).and_return(vcs_repository)
+    allow(vcs_repository).to receive(:destroy).with(any_args)
+    allow(vcs_repository).to receive(:restore)
+    allow(Travis::RemoteVCS::Organization).to receive(:new).and_return(vcs_organization)
+    allow(vcs_organization).to receive(:destroy)
+    allow(vcs_organization).to receive(:restore)
+    allow(Travis.logger).to receive(:error)
+  end
+
+  describe '#run' do
+    context 'with a valid payload for tool restriction' do
+      it 'calls destroy on the vcs_repository' do
+        expect(vcs_repository).to receive(:destroy).with(repository_id: '12345', vcs_type: 'AssemblaRepository')
+        service.run
+      end
+    end
+
+    context 'with a valid payload for tool restoration' do
+      let(:payload) { { 'action' => 'restore', 'object' => 'tool', 'id' => '12345' } }
+      it 'calls restore on the vcs_repository' do
+        expect(vcs_repository).to receive(:restore).with(repository_id: '12345')
+        service.run
+      end
+    end
+
+    context 'with a valid payload for space restriction' do
+      let(:payload) { { 'action' => 'restrict', 'object' => 'space', 'id' => '67890' } }
+
+      it 'calls destroy on the vcs_organization' do
+        expect(vcs_organization).to receive(:destroy).with(org_id: '67890')
+        service.run
+      end
+    end
+
+    context 'with a valid payload for space restoration' do
+      let(:payload) { { 'action' => 'restore', 'object' => 'space', 'id' => '67890' } }
+
+      it 'calls restore on the vcs_organization' do
+        expect(vcs_organization).to receive(:restore).with(org_id: '67890')
+        service.run
+      end
+    end
+
+    context 'with an invalid object type' do
+      let(:payload) { { 'action' => 'restrict', 'object' => 'repository', 'id' => '12345' } }
+
+      it 'returns false and logs an error' do
+        expect(service.run).to be_falsey
+        expect(Travis.logger).to have_received(:error).with("Invalid object type: repository. Allowed objects: space, tool")
+      end
+    end
+
+    context 'with an invalid action type' do
+      let(:payload) { { 'action' => 'modify', 'object' => 'tool', 'id' => '12345' } }
+
+      it 'returns false and logs an error' do
+        expect(service.run).to be_falsey
+        expect(Travis.logger).to have_received(:error).with("Invalid action: modify. Allowed actions: restrict, restore")
+      end
+    end
+
+    context 'with an unsupported object type for an action' do
+      before do
+        stub_const("Travis::Services::AssemblaNotifyService::VALID_OBJECTS", %w[space tool unsupported])
+      end
+      let(:payload) { { 'action' => 'restrict', 'object' => 'unsupported', 'id' => '12345' } }
+
+      it 'returns false without logging an error for the action' do
+        expect(service.run).to be_falsey
+        expect(vcs_repository).not_to receive(:destroy)
+        expect(vcs_repository).not_to receive(:restore)
+        expect(vcs_organization).not_to receive(:destroy)
+        expect(vcs_organization).not_to receive(:restore)
+      end
+    end
+  end
+end

spec/travis/remote_vcs/organization_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+require 'travis/remote_vcs/organization'
+
+RSpec.describe Travis::RemoteVCS::Organization do
+  let(:client) { described_class.new }
+  let(:org_id) { '12345' }
+  let(:subject) { client.destroy(org_id: org_id) }
+
+  describe '#destroy' do
+    it 'sends a delete request to the correct URL' do
+      request = double('request')
+      expect(request).to receive(:url).with("organizations/#{org_id}")
+      expect(client).to receive(:request).with(:delete, :destroy, false).and_yield(request)
+      subject
+    end
+
+    context 'when request is successful' do
+      before { allow(client).to receive(:request).and_return(true) }
+      it { is_expected.to be true }
+    end
+
+    context 'when the request fails' do
+      before { allow(client).to receive(:request).and_return(false) }
+      it { is_expected.to be false }
+    end
+  end
+end