Skip to content

Commit abc5d15

Browse files
committed
Terminal theme preview
1 parent afe01aa commit abc5d15

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

app/src/main/java/com/duy/editor/theme/TerminalThemeFragment.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import android.content.Context;
44
import android.os.Bundle;
5-
import android.preference.PreferenceManager;
65
import android.support.annotation.NonNull;
76
import android.support.annotation.Nullable;
87
import android.support.v4.app.Fragment;
@@ -40,26 +39,24 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
4039
public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
4140
super.onViewCreated(view, savedInstanceState);
4241
mPreferences = Preferences.getInstance(getContext());
42+
43+
mAdapter = new TerminalThemeAdapter(getContext());
44+
mAdapter.setOnThemeSelectListener((TerminalThemeAdapter.OnThemeSelectListener) getActivity());
45+
4346
mRecyclerView = view.findViewById(R.id.recyclerView);
4447
mRecyclerView.setLayoutManager(new LinearLayoutManager(getContext()));
4548
mRecyclerView.addItemDecoration(new DividerItemDecoration(getContext(), DividerItemDecoration.VERTICAL));
46-
mAdapter = new TerminalThemeAdapter(getContext());
47-
mAdapter.setOnThemeSelectListener((TerminalThemeAdapter.OnThemeSelectListener) getActivity());
4849
mRecyclerView.setAdapter(mAdapter);
49-
5050
}
5151

5252
public static class TerminalThemeAdapter extends RecyclerView.Adapter<TerminalThemeAdapter.ViewHolder> implements FastScrollRecyclerView.SectionedAdapter {
5353
private final String[] mThemes;
5454
private OnThemeSelectListener onThemeSelectListener;
55-
private TermSettings mTermSettings;
5655
private Context mContext;
5756

5857
public TerminalThemeAdapter(Context context) {
5958
mContext = context;
6059
mThemes = context.getResources().getStringArray(R.array.entries_emulator_color_preference);
61-
mTermSettings = new TermSettings(context.getResources(),
62-
PreferenceManager.getDefaultSharedPreferences(context));
6360
}
6461

6562
@NonNull
@@ -73,7 +70,7 @@ public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
7370
public void onBindViewHolder(@NonNull final ViewHolder holder, final int position) {
7471
EmulatorView termView = holder.mTermView;
7572
TermSession session = new TermSession();
76-
session.setTermIn(new StringBufferInputStream(mThemes[position]));
73+
session.setTermIn(new StringBufferInputStream(makeTitle(position, mThemes[position])));
7774
termView.attachSession(session);
7875
termView.setDensity(mContext.getResources().getDisplayMetrics());
7976
termView.setTextSize(16);
@@ -119,6 +116,7 @@ static class ViewHolder extends RecyclerView.ViewHolder {
119116

120117
ViewHolder(View itemView) {
121118
super(itemView);
119+
setIsRecyclable(false);
122120
mTermView = itemView.findViewById(R.id.term_view);
123121
mBtnSelect = itemView.findViewById(R.id.btn_select);
124122
}

app/src/main/java/com/duy/editor/theme/ThemeActivity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ protected void onDestroy() {
107107
public void onEditorThemeSelected(EditorTheme theme) {
108108
if (Premium.isPremiumUser(this)) {
109109
mPreferences.setEditorTheme(theme.getFileName());
110-
String text = getString(R.string.selected_theme, theme.getName());
110+
String text = getString(R.string.selected_editor_theme, theme.getName());
111111
Toast.makeText(this, text, Toast.LENGTH_SHORT).show();
112112
} else {
113113
PremiumDialog premiumDialog = new PremiumDialog(this, mInAppPurchaseHelper);
@@ -119,7 +119,7 @@ public void onEditorThemeSelected(EditorTheme theme) {
119119
public void onTerminalThemeSelected(String name, int index) {
120120
if (Premium.isPremiumUser(this)) {
121121
mPreferences.setTerminalTheme(index);
122-
String text = getString(R.string.selected_theme, name);
122+
String text = getString(R.string.selected_editor_theme, name);
123123
Toast.makeText(this, text, Toast.LENGTH_SHORT).show();
124124
} else {
125125
PremiumDialog premiumDialog = new PremiumDialog(this, mInAppPurchaseHelper);

app/src/main/res/layout/list_item_terminal.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<jackpal.androidterm.emulatorview.EmulatorView
99
android:id="@+id/term_view"
1010
android:layout_width="match_parent"
11-
android:layout_height="50dp"
11+
android:layout_height="70dp"
1212
tools:background="#000">
1313

1414
</jackpal.androidterm.emulatorview.EmulatorView>
@@ -17,7 +17,9 @@
1717
android:id="@+id/btn_select"
1818
android:layout_width="wrap_content"
1919
android:layout_height="wrap_content"
20-
android:layout_gravity="end"
20+
android:layout_gravity="bottom|end"
21+
android:layout_marginRight="8dp"
22+
android:layout_marginEnd="8dp"
2123
android:src="@drawable/baseline_check_24"
2224
android:text="Select" />
2325

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@
3434
</string>
3535

3636
<string name="button_purchase_restore">Restore</string>
37-
<string name="selected_theme">Selected %s. Restart app to apply theme.</string>
37+
<string name="selected_editor_theme">Selected %s. Restart app to apply theme.</string>
3838
<string name="terminal">Terminal</string>
3939
</resources>

0 commit comments

Comments
 (0)