fix index out of bound

Author: tranleduy2000

app/src/main/java/com/duy/ccppcompiler/compiler/CompileManager.java

@@ -81,14 +81,15 @@ private void finishCompile() {
     public void onCompileFailed(ShellResult shellResult) {
         finishCompile();
         if (mCompileDialog != null && mCompileDialog.isShowing()) {
-            mCompileDialog.setMessage(shellResult.getMessage());
+            mCompileDialog.dismiss();
         }
         if (DLog.DEBUG) DLog.w(TAG, "onCompileFailed: \n" + shellResult.getMessage());
         if (mDiagnosticPresenter != null) {
             DiagnosticsCollector diagnosticsCollector = new DiagnosticsCollector<>();
             OutputParser parser = new OutputParser(diagnosticsCollector);
             parser.parse(shellResult.getMessage());
             mDiagnosticPresenter.setDiagnostics(diagnosticsCollector.getDiagnostics());
+            mDiagnosticPresenter.showView();
         }
     }
 

app/src/main/java/com/duy/ccppcompiler/diagnostic/DiagnosticAdapter.java

@@ -70,12 +70,6 @@ public int getItemCount() {
         return mDiagnostics.size();
     }
 
-    public void addAll(List<Diagnostic> diagnostics) {
-        int start = mDiagnostics.size() - 1;
-        mDiagnostics.addAll(diagnostics);
-        notifyItemRangeInserted(start, start + diagnostics.size());
-    }
-
     public void remove(Diagnostic diagnostic) {
         int i = mDiagnostics.indexOf(diagnostic);
         if (i >= 0) {
@@ -102,6 +96,12 @@ public List<Diagnostic> getDiagnostics() {
         return mDiagnostics;
     }
 
+    public void setData(List<Diagnostic> diagnostics) {
+        mDiagnostics.clear();
+        mDiagnostics.addAll(diagnostics);
+        notifyDataSetChanged();
+    }
+
     static class ViewHolder extends RecyclerView.ViewHolder {
         TextView txtLine, txtCol, txtMessage, txtFile;
         View root;

app/src/main/java/com/duy/ccppcompiler/diagnostic/DiagnosticContract.java

@@ -39,5 +39,9 @@ public static interface View {
 
     public interface Presenter {
         void onDiagnosticClick(android.view.View view, Diagnostic diagnostic);
+
+        void showView();
+
+        void hideView();
     }
 }

app/src/main/java/com/duy/ccppcompiler/diagnostic/DiagnosticFragment.java

@@ -20,6 +20,7 @@
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import android.support.v4.app.Fragment;
+import android.support.v7.widget.DividerItemDecoration;
 import android.support.v7.widget.LinearLayoutManager;
 import android.support.v7.widget.RecyclerView;
 import android.view.LayoutInflater;
@@ -70,6 +71,9 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
 
         mRecyclerView = view.findViewById(R.id.diagnostic_list_view);
         mRecyclerView.setLayoutManager(new LinearLayoutManager(getContext()));
+        mRecyclerView.addItemDecoration(new DividerItemDecoration(getContext(),
+                DividerItemDecoration.VERTICAL));
+
         mAdapter = new DiagnosticAdapter(diagnostics, getContext());
         mAdapter.setDiagnosticClickListener(this);
         mRecyclerView.setAdapter(mAdapter);
@@ -84,12 +88,7 @@ public void onSaveInstanceState(@NonNull Bundle outState) {
 
     @Override
     public void show(List<Diagnostic> diagnostics) {
-        clear();
-        addAll(diagnostics);
-    }
-
-    private void addAll(List<Diagnostic> diagnostics) {
-        mAdapter.addAll(diagnostics);
+        mAdapter.setData(diagnostics);
     }
 
     @Override

app/src/main/java/com/duy/ccppcompiler/diagnostic/DiagnosticPresenter.java

@@ -22,6 +22,7 @@
 import com.duy.ccppcompiler.compiler.diagnostic.Diagnostic;
 import com.jecelyin.editor.v2.ui.activities.EditorActivity;
 import com.jecelyin.editor.v2.ui.manager.TabManager;
+import com.sothree.slidinguppanel.SlidingUpPanelLayout;
 
 import java.util.ArrayList;
 
@@ -50,6 +51,16 @@ public void onDiagnosticClick(View view, Diagnostic diagnostic) {
         // TODO: 28-Apr-18 implement
     }
 
+    @Override
+    public void showView() {
+        mActivity.mSlidingUpPanelLayout.setPanelState(SlidingUpPanelLayout.PanelState.EXPANDED);
+    }
+
+    @Override
+    public void hideView(){
+        mActivity.mSlidingUpPanelLayout.setPanelState(SlidingUpPanelLayout.PanelState.COLLAPSED);
+    }
+
     @MainThread
     public void setDiagnostics(ArrayList<Diagnostic> diagnostics) {
         this.diagnostics = diagnostics;

app/src/main/java/com/jecelyin/editor/v2/ui/activities/EditorActivity.java

@@ -106,14 +106,12 @@ public class EditorActivity extends FullScreenActivity
     public RecyclerView mTabRecyclerView;
     public TextView mVersionTextView;
     public SymbolBarLayout mSymbolBarLayout;
-
+    public SlidingUpPanelLayout mSlidingUpPanelLayout;
     private TabManager mTabManager;
-
     private Preferences mPreferences;
     private ClusterCommand clusterCommand;
     private MenuManager mMenuManager;
     private long mExitTime;
-    private SlidingUpPanelLayout mSlidingUpPanelLayout;
     private DiagnosticPresenter mDiagnosticPresenter;
 
     @Override