Skip to content

Commit 51577ab

Browse files
committed
Hide panel when click diagnostic item
1 parent 3d6aca1 commit 51577ab

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

app/src/main/java/com/duy/ccppcompiler/compiler/manager/CompileManagerImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public void onCompileFailed(CommandResult compileResult) {
9292
finishCompile(compileResult);
9393

9494
if (mDiagnosticPresenter != null) {
95-
mDiagnosticPresenter.expandView();
95+
mDiagnosticPresenter.showPanel();
9696
}
9797

9898
Toast.makeText(mActivity, "Compiled failed", Toast.LENGTH_LONG).show();

libeditor/src/main/java/com/duy/ide/diagnostic/DiagnosticContract.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ public interface Presenter {
5252
void onSuggestionClick(Diagnostic diagnostic, ISuggestion suggestion);
5353

5454
@MainThread
55-
void expandView();
55+
void showPanel();
5656

5757
@MainThread
58-
void hideView();
58+
void hidePanel();
5959

6060
@MainThread
6161
void setDiagnostics(ArrayList<Diagnostic> diagnostics);

libeditor/src/main/java/com/duy/ide/diagnostic/DiagnosticPresenter.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ public void onDiagnosticClick(View view, Diagnostic diagnostic) {
8282
command.args.putInt("col", (int) diagnostic.getColumnNumber());
8383
editorDelegate.doCommand(command);
8484
}
85+
hidePanel();
8586
}
8687
}
8788

@@ -131,12 +132,12 @@ private IEditorDelegate moveToEditor(File source, @Nullable byte[] md5) {
131132
}
132133

133134
@Override
134-
public void expandView() {
135+
public void showPanel() {
135136
mActivity.mSlidingUpPanelLayout.setPanelState(SlidingUpPanelLayout.PanelState.EXPANDED);
136137
}
137138

138139
@Override
139-
public void hideView() {
140+
public void hidePanel() {
140141
mActivity.mSlidingUpPanelLayout.setPanelState(SlidingUpPanelLayout.PanelState.COLLAPSED);
141142
}
142143

0 commit comments

Comments
 (0)