Add automatic acts_as declaration updates to upgrade generator

- Upgrade generator now automatically rewrites existing models' acts_as declarations
- Updates Chat, Message, and ToolCall models to include proper model associations
- Create shared GeneratorHelpers module to DRY up generator code
- Add automatic namespace module creation with table_name_prefix for namespaced models
- Fix template paths in upgrade generator to use source_paths correctly
- Update docs to highlight automatic acts_as updates as key feature
- Delete implementation detail tests that check source code strings

Author: crmne

docs/_advanced/upgrading-to-1.7.md

@@ -34,7 +34,9 @@ rails db:migrate
 That's it! The generator:
 - Creates the models table if needed
 - Automatically adds `config.use_new_acts_as = true` to your initializer
+- Automatically updates your existing models' `acts_as` declarations to the new version
 - Migrates your existing data to use foreign keys
+- Loads the models in the db
 - Preserves all your data (old string columns renamed to `model_id_string`)
 
 ### Custom Model Names

lib/generators/ruby_llm/generator_helpers.rb

@@ -0,0 +1,129 @@
+# frozen_string_literal: true
+
+module RubyLLM
+  # Shared helpers for RubyLLM generators
+  module GeneratorHelpers
+    def parse_model_mappings
+      @model_names = {
+        chat: 'Chat',
+        message: 'Message',
+        tool_call: 'ToolCall',
+        model: 'Model'
+      }
+
+      model_mappings.each do |mapping|
+        if mapping.include?(':')
+          key, value = mapping.split(':', 2)
+          @model_names[key.to_sym] = value.classify
+        end
+      end
+
+      @model_names
+    end
+
+    %i[chat message tool_call model].each do |type|
+      define_method("#{type}_model_name") do
+        @model_names ||= parse_model_mappings
+        @model_names[type]
+      end
+
+      define_method("#{type}_table_name") do
+        table_name_for(send("#{type}_model_name"))
+      end
+    end
+
+    def acts_as_chat_declaration
+      params = []
+
+      add_association_params(params, :messages, message_table_name, message_model_name, plural: true)
+      add_association_params(params, :model, model_table_name, model_model_name)
+
+      "acts_as_chat#{" #{params.join(', ')}" if params.any?}"
+    end
+
+    def acts_as_message_declaration
+      params = []
+
+      add_association_params(params, :chat, chat_table_name, chat_model_name)
+      add_association_params(params, :tool_calls, tool_call_table_name, tool_call_model_name, plural: true)
+      add_association_params(params, :model, model_table_name, model_model_name)
+
+      "acts_as_message#{" #{params.join(', ')}" if params.any?}"
+    end
+
+    def acts_as_model_declaration
+      params = []
+
+      add_association_params(params, :chats, chat_table_name, chat_model_name, plural: true)
+
+      "acts_as_model#{" #{params.join(', ')}" if params.any?}"
+    end
+
+    def acts_as_tool_call_declaration
+      params = []
+
+      add_association_params(params, :message, message_table_name, message_model_name)
+
+      "acts_as_tool_call#{" #{params.join(', ')}" if params.any?}"
+    end
+
+    def create_namespace_modules
+      namespaces = []
+
+      [chat_model_name, message_model_name, tool_call_model_name, model_model_name].each do |model_name|
+        if model_name.include?('::')
+          namespace = model_name.split('::').first
+          namespaces << namespace unless namespaces.include?(namespace)
+        end
+      end
+
+      namespaces.each do |namespace|
+        module_path = "app/models/#{namespace.underscore}.rb"
+        next if File.exist?(Rails.root.join(module_path))
+
+        create_file module_path do
+          <<~RUBY
+            module #{namespace}
+              def self.table_name_prefix
+                "#{namespace.underscore}_"
+              end
+            end
+          RUBY
+        end
+      end
+    end
+
+    def migration_version
+      "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
+    end
+
+    def postgresql?
+      ::ActiveRecord::Base.connection.adapter_name.downcase.include?('postgresql')
+    rescue StandardError
+      false
+    end
+
+    def table_exists?(table_name)
+      ::ActiveRecord::Base.connection.table_exists?(table_name)
+    rescue StandardError
+      false
+    end
+
+    private
+
+    def add_association_params(params, default_assoc, table_name, model_name, plural: false)
+      assoc = plural ? table_name.to_sym : table_name.singularize.to_sym
+
+      return if assoc == default_assoc
+
+      params << "#{default_assoc}: :#{assoc}"
+      params << "#{default_assoc.to_s.singularize}_class: '#{model_name}'" if model_name != assoc.to_s.classify
+    end
+
+    def table_name_for(model_name)
+      # Convert namespaced model names to proper table names
+      # e.g., "Assistant::Chat" -> "assistant_chats" (not "assistant/chats")
+      model_name.underscore.pluralize.tr('/', '_')
+    end
+  end
+end

lib/generators/ruby_llm/install/install_generator.rb

@@ -2,11 +2,13 @@
 
 require 'rails/generators'
 require 'rails/generators/active_record'
+require_relative '../generator_helpers'
 
 module RubyLLM
   # Generator for RubyLLM Rails models and migrations
   class InstallGenerator < Rails::Generators::Base
     include Rails::Generators::Migration
+    include RubyLLM::GeneratorHelpers
 
     namespace 'ruby_llm:install'
 
@@ -24,80 +26,6 @@ def self.next_migration_number(dirname)
       ::ActiveRecord::Generators::Base.next_migration_number(dirname)
     end
 
-    def migration_version
-      "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
-    end
-
-    def postgresql?
-      ::ActiveRecord::Base.connection.adapter_name.downcase.include?('postgresql')
-    rescue StandardError
-      false
-    end
-
-    def parse_model_mappings
-      @model_names = {
-        chat: 'Chat',
-        message: 'Message',
-        tool_call: 'ToolCall',
-        model: 'Model'
-      }
-
-      model_mappings.each do |mapping|
-        if mapping.include?(':')
-          key, value = mapping.split(':', 2)
-          @model_names[key.to_sym] = value.classify
-        end
-      end
-
-      @model_names
-    end
-
-    %i[chat message tool_call model].each do |type|
-      define_method("#{type}_model_name") do
-        @model_names ||= parse_model_mappings
-        @model_names[type]
-      end
-
-      define_method("#{type}_table_name") do
-        table_name_for(send("#{type}_model_name"))
-      end
-    end
-
-    def acts_as_chat_declaration
-      params = []
-
-      add_association_params(params, :messages, message_table_name, message_model_name, plural: true)
-      add_association_params(params, :model, model_table_name, model_model_name)
-
-      "acts_as_chat#{" #{params.join(', ')}" if params.any?}"
-    end
-
-    def acts_as_message_declaration
-      params = []
-
-      add_association_params(params, :chat, chat_table_name, chat_model_name)
-      add_association_params(params, :tool_calls, tool_call_table_name, tool_call_model_name, plural: true)
-      add_association_params(params, :model, model_table_name, model_model_name)
-
-      "acts_as_message#{" #{params.join(', ')}" if params.any?}"
-    end
-
-    def acts_as_model_declaration
-      params = []
-
-      add_association_params(params, :chats, chat_table_name, chat_model_name, plural: true)
-
-      "acts_as_model#{" #{params.join(', ')}" if params.any?}"
-    end
-
-    def acts_as_tool_call_declaration
-      params = []
-
-      add_association_params(params, :message, message_table_name, message_model_name)
-
-      "acts_as_tool_call#{" #{params.join(', ')}" if params.any?}"
-    end
-
     def create_migration_files
       # Create migrations with timestamps to ensure proper order
       # First create chats table
@@ -121,6 +49,8 @@ def create_migration_files
     end
 
     def create_model_files
+      create_namespace_modules
+
       template 'chat_model.rb.tt', "app/models/#{chat_model_name.underscore}.rb"
       template 'message_model.rb.tt', "app/models/#{message_model_name.underscore}.rb"
       template 'tool_call_model.rb.tt', "app/models/#{tool_call_model_name.underscore}.rb"
@@ -170,22 +100,5 @@ def show_install_info
       say '     • 🐦 Follow for updates: https://x.com/paolino'
       say "\n"
     end
-
-    private
-
-    def add_association_params(params, default_assoc, table_name, model_name, plural: false)
-      assoc = plural ? table_name.to_sym : table_name.singularize.to_sym
-
-      return if assoc == default_assoc
-
-      params << "#{default_assoc}: :#{assoc}"
-      params << "#{default_assoc.to_s.singularize}_class: '#{model_name}'" if model_name != assoc.to_s.classify
-    end
-
-    def table_name_for(model_name)
-      # Convert namespaced model names to proper table names
-      # e.g., "Assistant::Chat" -> "assistant_chats" (not "assistant/chats")
-      model_name.underscore.pluralize.tr('/', '_')
-    end
   end
 end

lib/generators/ruby_llm/install/templates/create_models_migration.rb.tt

@@ -34,10 +34,7 @@ class Create<%= model_model_name.gsub('::', '').pluralize %> < ActiveRecord::Mig
     # Load models from JSON
     say_with_time "Loading models from models.json" do
       RubyLLM.models.load_from_json!
-      model_class = '<%= model_model_name %>'.constantize
-      model_class.save_to_database
-
-      "Loaded #{model_class.count} models"
+      <%= model_model_name %>.save_to_database
     end
   end
 end