ci: Simplify validate-config CI workflow

Author: markmetcalfe

.github/workflows/build-image.yml

@@ -26,7 +26,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        uses: actions/checkout@v4
         with:
           fetch-depth: 1
       - name: Log in to Docker Hub
@@ -50,7 +50,7 @@ jobs:
         uses: docker/setup-buildx-action@c47758b77c9736f4b2ef4073d4d51994fabfe349 # v3.7.1
         with:
           platforms: ${{ inputs.multiarch == true && 'linux/amd64,linux/arm64' || 'linux/amd64' }}
-      - name: Build and push images
+      - name: Build and push image
         uses: docker/build-push-action@4f58ea79222b3b9dc2c8bbdd6debcef730109a75 # v6.9.0
         with:
           context: ${{ inputs.context }}

.github/workflows/validate-config-for-version.yml

@@ -6,14 +6,40 @@ on:
       - 'config.php'
       - 'php/includes/**'
       - '.github/workflows/validate-config.yml'
-      - '.github/workflows/validate-config-for-version.yml'
 
 jobs:
   validate-config:
-    uses: ./.github/workflows/validate-config-for-version.yml
+    name: Validate for PHP ${{ matrix.php-version }}
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: true
       matrix:
         php-version: ['8.4', '5.5']
-    with:
-      php-version: ${{ matrix.php-version }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+      - name: Create symlinks for config.php includes
+        run: |
+          sudo mkdir -p /var/www/totara
+          sudo ln -sf "$GITHUB_WORKSPACE/php/includes" /var/www/totara/includes
+      - name: Set up PHP ${{ matrix.php-version }}
+        uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
+        with:
+          php-version: ${{ matrix.php-version }}
+      - name: Validate config.php syntax (PHP ${{ matrix.php-version }})
+        run: php -l ./config.php && find ./php/includes -name '*.php' -exec php -l {} +
+      - name: Check that required $CFG variables are defined (PHP ${{ matrix.php-version }})
+        run: |
+          php -r '
+            define("CLI_SCRIPT", true);
+            define("ABORT_AFTER_CONFIG", true);
+            include "config.php";
+            foreach (["dbhost", "dbtype", "dbuser", "dbpass", "dbname", "prefix", "wwwroot", "dataroot"] as $var) {
+              if (!isset($CFG->{$var})) {
+                fwrite(STDERR, "Missing \$CFG->{$var} from config.php (or from php/includes/) - is it commented out?\n");
+                exit(1);
+              }
+            }
+          '