Replace tabs with spaces

Author: aarondfrancis

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+## 0.5.2 - 2021-08-02
+
+### Fixed
+- Replace tabs with spaces in code before it's sent to the API.
+
 ## 0.5.1 - 2021-08-01
 
 ### Added

src/Block.php

@@ -202,7 +202,21 @@ public function toRequestParams()
      */
     protected function clean($code)
     {
-        return $this->dedent(rtrim($code));
+        $code = rtrim($code);
+        $code = $this->replaceTabs($code);
+
+        return $this->dedent($code);
+    }
+
+    /**
+     * @param $code
+     * @return string
+     */
+    protected function replaceTabs($code)
+    {
+        $multiplier = Torchlight::config('spaces_per_tab', 4);
+
+        return str_replace("\t", str_repeat(" ", $multiplier), $code);
     }
 
     /**

tests/BlockTest.php

@@ -6,6 +6,7 @@
 namespace Torchlight\Tests;
 
 use Torchlight\Block;
+use Torchlight\Torchlight;
 
 class BlockTest extends BaseTest
 {
@@ -23,7 +24,7 @@ public function it_dedents_code()
 
         $block->code($code);
 
-        $dedented = $code = <<<EOT
+        $dedented = <<<EOT
 echo 1;
 if (1) {
     return;
@@ -33,6 +34,46 @@ public function it_dedents_code()
         $this->assertEquals($block->code, $dedented);
     }
 
+    /** @test */
+    public function it_replaces_tabs()
+    {
+        $block = Block::make();
+
+        $block->code("if (1) {\n\tif (1) {\n\t\treturn;\n\t}\n}");
+
+        $cleaned = <<<EOT
+if (1) {
+    if (1) {
+        return;
+    }
+}
+EOT;
+
+        $this->assertEquals($block->code, $cleaned);
+    }
+
+    /** @test */
+    public function can_change_tab_size()
+    {
+        Torchlight::getConfigUsing([
+            'spaces_per_tab' => 2
+        ]);
+
+        $block = Block::make();
+
+        $block->code("if (1) {\n\tif (1) {\n\t\treturn;\n\t}\n}");
+
+        $cleaned = <<<EOT
+if (1) {
+  if (1) {
+    return;
+  }
+}
+EOT;
+
+        $this->assertEquals($block->code, $cleaned);
+    }
+
     /** @test */
     public function it_right_trims()
     {
@@ -41,6 +82,7 @@ public function it_right_trims()
         $this->assertEquals($block->code, 'echo 1;');
     }
 
+
     /** @test */
     public function you_can_set_your_own_id()
     {