Skip to content

Commit ddf4170

Browse files
committed
Better matching for "Checkpoint Screening" "Iterative Review", "Checkpoint Review"
1 parent 97d7e07 commit ddf4170

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

.local-ssl-proxy.pid

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
127525
1+
321029

src/components/ChallengeEditor/ChallengeReviewer-Field/index.js

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,27 @@ class ChallengeReviewerField extends Component {
543543
const validationErrors = challenge.submitTriggered ? this.validateReviewer(reviewer) : {}
544544
const selectedPhase = challenge.phases.find(p => p.phaseId === reviewer.phaseId)
545545
const isDesignChallenge = challenge && challenge.trackId === DES_TRACK_ID
546-
const filteredScorecards = scorecards.filter(item => (item.type && item.type.toLowerCase()) === (selectedPhase && selectedPhase.name.toLowerCase()))
546+
const normalize = (value) => (value || '')
547+
.toString()
548+
.toLowerCase()
549+
.trim()
550+
.replace(/\bphase\b$/, '')
551+
.replace(/[-_\s]/g, '')
552+
553+
const filteredScorecards = scorecards.filter(item => {
554+
if (!selectedPhase || !selectedPhase.name || !item || !item.type) {
555+
return false
556+
}
557+
558+
const normalizedType = normalize(item.type)
559+
const normalizedPhaseName = normalize(selectedPhase.name)
560+
561+
if (!normalizedType || !normalizedPhaseName) {
562+
return false
563+
}
564+
565+
return normalizedType === normalizedPhaseName
566+
})
547567

548568
return (
549569
<div key={`reviewer-${index}`} className={styles.reviewerForm}>

0 commit comments

Comments
 (0)