Skip to content

Commit 8f81df8

Browse files
authored
Merge pull request #1707 from topcoder-platform/fix-lint
fix: lint
2 parents 8fe72fb + 4d76def commit 8f81df8

File tree

1 file changed

+40
-40
lines changed
  • src/components/ChallengeEditor/ChallengeReviewer-Field

1 file changed

+40
-40
lines changed

src/components/ChallengeEditor/ChallengeReviewer-Field/index.js

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -760,57 +760,57 @@ class ChallengeReviewerField extends Component {
760760
onChange={(e) => this.updateReviewer(index, 'phaseId', e.target.value)}
761761
>
762762
<option value=''>Select Phase</option>
763-
{challenge.phases && challenge.phases
764-
.filter(phase => {
765-
const rawName = phase.name ? phase.name : ''
766-
const phaseName = rawName.toLowerCase()
767-
const norm = phaseName.replace(/[-\s]/g, '')
768-
const isReviewPhase = phaseName.includes('review')
769-
const isSubmissionPhase = phaseName.includes('submission')
770-
const isScreeningPhase = norm === 'screening' || norm === 'checkpointscreening'
771-
const isApprovalPhase = norm === 'approval'
772-
const isPostMortemPhase = norm === 'postmortem'
773-
const isCurrentlySelected = reviewer.phaseId && ((phase.id === reviewer.phaseId) || (phase.phaseId === reviewer.phaseId)) && !isSubmissionPhase
774-
775-
// Collect phases already assigned to other reviewers (excluding current reviewer)
776-
const assignedPhaseIds = new Set(
777-
(challenge.reviewers || [])
778-
.filter((r, i) => i !== index)
779-
.map(r => r.phaseId)
780-
.filter(id => id !== undefined && id !== null)
781-
)
763+
{challenge.phases && challenge.phases
764+
.filter(phase => {
765+
const rawName = phase.name ? phase.name : ''
766+
const phaseName = rawName.toLowerCase()
767+
const norm = phaseName.replace(/[-\s]/g, '')
768+
const isReviewPhase = phaseName.includes('review')
769+
const isSubmissionPhase = phaseName.includes('submission')
770+
const isScreeningPhase = norm === 'screening' || norm === 'checkpointscreening'
771+
const isApprovalPhase = norm === 'approval'
772+
const isPostMortemPhase = norm === 'postmortem'
773+
const isCurrentlySelected = reviewer.phaseId && ((phase.id === reviewer.phaseId) || (phase.phaseId === reviewer.phaseId)) && !isSubmissionPhase
774+
775+
// Collect phases already assigned to other reviewers (excluding current reviewer)
776+
const assignedPhaseIds = new Set(
777+
(challenge.reviewers || [])
778+
.filter((r, i) => i !== index)
779+
.map(r => r.phaseId)
780+
.filter(id => id !== undefined && id !== null)
781+
)
782782

783-
// Exclude phases already assigned to other reviewers, except the currently selected phase
784-
if (assignedPhaseIds.has(phase.phaseId || phase.id) && !isCurrentlySelected) {
785-
return false
786-
}
783+
// Exclude phases already assigned to other reviewers, except the currently selected phase
784+
if (assignedPhaseIds.has(phase.phaseId || phase.id) && !isCurrentlySelected) {
785+
return false
786+
}
787787

788-
// For AI reviewers, allow review, submission, and other required phases
789-
// For member reviewers, allow review and other required phases
790-
if (this.isAIReviewer(reviewer)) {
791-
return (
792-
isReviewPhase ||
788+
// For AI reviewers, allow review, submission, and other required phases
789+
// For member reviewers, allow review and other required phases
790+
if (this.isAIReviewer(reviewer)) {
791+
return (
792+
isReviewPhase ||
793793
isSubmissionPhase ||
794794
isScreeningPhase ||
795795
isApprovalPhase ||
796796
isPostMortemPhase ||
797797
isCurrentlySelected
798-
)
799-
} else {
800-
return (
801-
isReviewPhase ||
798+
)
799+
} else {
800+
return (
801+
isReviewPhase ||
802802
isScreeningPhase ||
803803
isApprovalPhase ||
804804
isPostMortemPhase ||
805805
isCurrentlySelected
806-
)
807-
}
808-
})
809-
.map(phase => (
810-
<option key={phase.id || phase.phaseId} value={phase.phaseId || phase.id}>
811-
{phase.name || `Phase ${phase.phaseId || phase.id}`}
812-
</option>
813-
))}
806+
)
807+
}
808+
})
809+
.map(phase => (
810+
<option key={phase.id || phase.phaseId} value={phase.phaseId || phase.id}>
811+
{phase.name || `Phase ${phase.phaseId || phase.id}`}
812+
</option>
813+
))}
814814
</select>
815815
)}
816816
{!readOnly && challenge.submitTriggered && validationErrors.phaseId && (

0 commit comments

Comments
 (0)