Skip to content

Commit 78cd057

Browse files
authored
Merge pull request #1348 from nursoltan-s/fix-phase-issue
fix phase issue
2 parents 8c0c626 + b32911d commit 78cd057

File tree

3 files changed

+17
-5
lines changed

3 files changed

+17
-5
lines changed

src/components/ChallengeEditor/index.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1242,7 +1242,14 @@ class ChallengeEditor extends Component {
12421242
*/
12431243
isPhaseEditable (phaseIndex) {
12441244
const { phases } = this.state.challenge
1245-
return moment(phases[phaseIndex].scheduledEndDate).isAfter(moment())
1245+
const phase = phases[phaseIndex]
1246+
if (phase.name === 'Registration' && moment(phase.scheduledEndDate).isAfter(moment())) {
1247+
return true
1248+
}
1249+
if (!phase.isOpen) {
1250+
return false
1251+
}
1252+
return moment(phase.scheduledEndDate).isAfter(moment())
12461253
}
12471254

12481255
render () {

src/components/DurationInput/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,10 @@ const DurationInput = ({ duration, onDurationChange, index, isActive }) => {
1515
min={0}
1616
type='number'
1717
value={Number(duration).toString()}
18-
onChange={e => onDurationChange(e.target.value)}
18+
onChange={e => {
19+
e.preventDefault()
20+
onDurationChange(e.target.value)
21+
}}
1922
autoFocus={inputRef.current === document.activeElement}
2023
disabled={!isActive}
2124
/>

src/util/date.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,13 @@ export const updateChallengePhaseBeforeSendRequest = (challengeDetail) => {
110110
if (challengeDetail.phases) {
111111
const challengeDetailTmp = _.cloneDeep(challengeDetail)
112112
challengeDetailTmp.startDate = challengeDetail.phases[0].scheduledStartDate
113+
// challengeDetailTmp.registrationStartDate = moment(challengeDetail.phases[0].scheduledStartDate)
114+
// challengeDetailTmp.registrationEndDate = moment(challengeDetail.phases[0].scheduledEndDate)
115+
// challengeDetailTmp.submissionStartDate = moment(challengeDetail.phases[1].scheduledStartDate)
116+
// challengeDetailTmp.submissionEndDate = moment(challengeDetail.phases[1].scheduledEndDate)
113117
challengeDetailTmp.phases = challengeDetailTmp.phases.map((p) => ({
114118
duration: p.duration * hourToSecond,
115-
phaseId: p.phaseId,
116-
scheduledStartDate: p.scheduledStartDate,
117-
scheduledEndDate: p.scheduledEndDate
119+
phaseId: p.phaseId
118120
}))
119121
return challengeDetailTmp
120122
}

0 commit comments

Comments
 (0)