Commit 6d85168
committed
Fix billing account status display
#1412
1. A "project" contains "status" field , this status field can be "active"/"in_review"
2. A "project" also has a billingAccount mapped.
3. Application makes a GET call with billingAccount id to get billingAccount details. and response of it is this screenshot https://imgur.com/cU3s4yU
4. response has "active" boolean field and enddate field which is correctly utilised in reducer code to set the flag "isBillingAccountExpired". check this screenshot https://imgur.com/l5nyxbt
5. now this "isBillingAccountExpired" flag is used like this. check screenshot https://imgur.com/mjDhbAF
6. when "isBillingAccountExpired" is true, we show hardcoded "INACTIVE" which is correct.
7. but when "isBillingAccountExpired" is false , we show "status" field of "project" which is wrong, because we need to show whether billingAccount is active or not.
8. hence "status" field of project can be active/inReview , thats why u see "IN_REVIEW" in UI,
9. hence my solution/approach is that flag "isBillingAccountExpired" is already there which clearly indicates active/inactive, hence i hardcoded "ACTIVE" in code because it is obvious.1 parent 62952a5 commit 6d85168
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
| 181 | + | |
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
| |||
0 commit comments