fixed unit tests for strengthened endpoints

Author: Vikas Agarwal

src/routes/productTemplates/create.spec.js

@@ -67,6 +67,16 @@ describe('CREATE product template', () => {
         .expect(403, done);
     });
 
+    it('should return 403 for connect manager', (done) => {
+      request(server)
+        .post('/v4/productTemplates')
+        .set({
+          Authorization: `Bearer ${testUtil.jwts.manager}`,
+        })
+        .send(body)
+        .expect(403, done);
+    });
+
     it('should return 422 if validations dont pass', (done) => {
       const invalidBody = {
         param: {
@@ -118,23 +128,6 @@ describe('CREATE product template', () => {
         });
     });
 
-    it('should return 201 for connect manager', (done) => {
-      request(server)
-        .post('/v4/productTemplates')
-        .set({
-          Authorization: `Bearer ${testUtil.jwts.manager}`,
-        })
-        .send(body)
-        .expect('Content-Type', /json/)
-        .expect(201)
-        .end((err, res) => {
-          const resJson = res.body.result.content;
-          resJson.createdBy.should.be.eql(40051334); // manager
-          resJson.updatedBy.should.be.eql(40051334); // manager
-          done();
-        });
-    });
-
     it('should return 201 for connect admin', (done) => {
       request(server)
         .post('/v4/productTemplates')

src/routes/productTemplates/delete.spec.js

@@ -69,6 +69,15 @@ describe('DELETE product template', () => {
         .expect(403, done);
     });
 
+    it('should return 403 for connect manager', (done) => {
+      request(server)
+        .delete(`/v4/productTemplates/${templateId}`)
+        .set({
+          Authorization: `Bearer ${testUtil.jwts.manager}`,
+        })
+        .expect(403, done);
+    });
+
     it('should return 404 for non-existed template', (done) => {
       request(server)
         .delete('/v4/productTemplates/1234')
@@ -109,15 +118,5 @@ describe('DELETE product template', () => {
         .expect(204)
         .end(done);
     });
-
-    it('should return 204, for connect manager, if template was successfully removed', (done) => {
-      request(server)
-        .delete(`/v4/productTemplates/${templateId}`)
-        .set({
-          Authorization: `Bearer ${testUtil.jwts.manager}`,
-        })
-        .expect(204)
-        .end(done);
-    });
   });
 });

src/routes/productTemplates/update.spec.js

@@ -120,6 +120,16 @@ describe('UPDATE product template', () => {
         .expect(403, done);
     });
 
+    it('should return 403 for connect manager', (done) => {
+      request(server)
+        .patch(`/v4/productTemplates/${templateId}`)
+        .send(body)
+        .set({
+          Authorization: `Bearer ${testUtil.jwts.manager}`,
+        })
+        .expect(403, done);
+    });
+
     it('should return 422 for invalid request', (done) => {
       const invalidBody = {
         param: {
@@ -233,16 +243,5 @@ describe('UPDATE product template', () => {
         .expect(200)
         .end(done);
     });
-
-    it('should return 200 for connect manager', (done) => {
-      request(server)
-        .patch(`/v4/productTemplates/${templateId}`)
-        .set({
-          Authorization: `Bearer ${testUtil.jwts.manager}`,
-        })
-        .send(body)
-        .expect(200)
-        .end(done);
-    });
   });
 });

src/routes/projectTemplates/create.spec.js

@@ -75,6 +75,16 @@ describe('CREATE project template', () => {
         .expect(403, done);
     });
 
+    it('should return 403 for connect manager', (done) => {
+      request(server)
+        .post('/v4/projectTemplates')
+        .set({
+          Authorization: `Bearer ${testUtil.jwts.manager}`,
+        })
+        .send(body)
+        .expect(403, done);
+    });
+
     it('should return 422 if validations dont pass', (done) => {
       const invalidBody = {
         param: {
@@ -124,23 +134,6 @@ describe('CREATE project template', () => {
         });
     });
 
-    it('should return 201 for connect manager', (done) => {
-      request(server)
-        .post('/v4/projectTemplates')
-        .set({
-          Authorization: `Bearer ${testUtil.jwts.manager}`,
-        })
-        .send(body)
-        .expect('Content-Type', /json/)
-        .expect(201)
-        .end((err, res) => {
-          const resJson = res.body.result.content;
-          resJson.createdBy.should.be.eql(40051334); // manager
-          resJson.updatedBy.should.be.eql(40051334); // manager
-          done();
-        });
-    });
-
     it('should return 201 for connect admin', (done) => {
       request(server)
         .post('/v4/projectTemplates')

src/routes/projectTemplates/delete.spec.js

@@ -77,6 +77,15 @@ describe('DELETE project template', () => {
         .expect(403, done);
     });
 
+    it('should return 403 for connect manager', (done) => {
+      request(server)
+        .delete(`/v4/projectTemplates/${templateId}`)
+        .set({
+          Authorization: `Bearer ${testUtil.jwts.manager}`,
+        })
+        .expect(403, done);
+    });
+
     it('should return 404 for non-existed template', (done) => {
       request(server)
         .delete('/v4/projectTemplates/1234')
@@ -117,15 +126,5 @@ describe('DELETE project template', () => {
         .expect(204)
         .end(done);
     });
-
-    it('should return 204, for connect manager, if template was successfully removed', (done) => {
-      request(server)
-        .delete(`/v4/projectTemplates/${templateId}`)
-        .set({
-          Authorization: `Bearer ${testUtil.jwts.manager}`,
-        })
-        .expect(204)
-        .end(done);
-    });
   });
 });

src/routes/projectTemplates/update.spec.js

@@ -120,6 +120,16 @@ describe('UPDATE project template', () => {
         .expect(403, done);
     });
 
+    it('should return 403 for connect manager', (done) => {
+      request(server)
+        .patch(`/v4/projectTemplates/${templateId}`)
+        .send(body)
+        .set({
+          Authorization: `Bearer ${testUtil.jwts.manager}`,
+        })
+        .expect(403, done);
+    });
+
     it('should return 422 for invalid request', (done) => {
       const invalidBody = {
         param: {
@@ -230,16 +240,5 @@ describe('UPDATE project template', () => {
         .expect(200)
         .end(done);
     });
-
-    it('should return 200 for connect manager', (done) => {
-      request(server)
-        .patch(`/v4/projectTemplates/${templateId}`)
-        .set({
-          Authorization: `Bearer ${testUtil.jwts.manager}`,
-        })
-        .send(body)
-        .expect(200)
-        .end(done);
-    });
   });
 });