Skip to content

Commit a7a2b56

Browse files
author
Maksym Mykhailenko
committed
fix: invite by handles
when invite by handle only search for users with exact handle we are inviting by
1 parent a647090 commit a7a2b56

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/routes/projectMemberInvites/create.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,12 @@ module.exports = [
270270
}
271271

272272
// get member details by handles first
273-
return util.getMemberDetailsByHandles(invite.handles, req.log, req.id).then((inviteUsers) => {
273+
return util.getMemberDetailsByHandles(invite.handles, req.log, req.id)
274+
// we have to filter users returned by the Message Service so we only invite the users
275+
// whom we are inviting, because Message Service has a loose search logic and may return
276+
// users with handles whom we didn't search for
277+
.then(foundUsers => foundUsers.filter(foundUser => _.includes(invite.handles, foundUser.handle)))
278+
.then((inviteUsers) => {
274279
const members = req.context.currentProjectMembers;
275280
const projectId = _.parseInt(req.params.projectId);
276281
// check user handle exists in returned result

0 commit comments

Comments
 (0)