More permissions update

Author: Vikas Agarwal

src/routes/projectReports/LookRun.js

@@ -38,18 +38,23 @@ LookApi.prototype.findProjectRegSubmissions = function (projectId) {
   return this.runQueryWithFilter(queryId, view, fields, filters);
 };
 
-LookApi.prototype.findProjectBudget = function (connectProjectId, isManager, isAdmin) {
+LookApi.prototype.findProjectBudget = function (connectProjectId, permissions) {
   const queryId = config.lookerConfig.QUERIES.BUDGET;
+  const { isManager, isAdmin, isCopilot, isCustomer } = permissions;
 
   const fields = [
     'project_stream.tc_connect_project_id',
-    'project_stream.total_invoiced_amount',
-    'project_stream.remaining_invoiced_budget',
   ];
 
   // Manager roles have access to more fields.
   if (isManager || isAdmin) {
-    fields.push('project_stream.total_actual_challenge_fee', 'project_stream.total_actual_member_payment');
+    fields.push('project_stream.total_actual_challenge_fee');
+  }
+  if (isManager || isAdmin || isCopilot) {
+    fields.push('project_stream.total_actual_member_payment');
+  }
+  if (isManager || isAdmin || isCustomer) {
+    fields.push('project_stream.total_invoiced_amount', 'project_stream.remaining_invoiced_budget');
   }
   const view = 'project_stream';
   const filters = { 'project_stream.tc_connect_project_id': connectProjectId };

src/routes/projectReports/getReport.js

@@ -3,11 +3,10 @@ import config from 'config';
 import _ from 'lodash';
 
 import { middleware as tcMiddleware } from 'tc-core-library-js';
-import models from '../../models';
 import LookApi from './LookRun';
 import mock from './mock';
 import util from '../../util';
-import { PROJECT_MEMBER_MANAGER_ROLES, USER_ROLE } from '../../constants';
+import { PROJECT_MEMBER_MANAGER_ROLES, USER_ROLE, PROJECT_MEMBER_ROLE } from '../../constants';
 
 const permissions = tcMiddleware.permissions;
 
@@ -32,14 +31,16 @@ module.exports = [
       const member = _.find(members, m => m.userId === req.authUser.userId);
       const isManager = member && PROJECT_MEMBER_MANAGER_ROLES.indexOf(member.role) > -1;
       const isAdmin = util.hasRoles(req, [USER_ROLE.CONNECT_ADMIN, USER_ROLE.TOPCODER_ADMIN]);
+      const isCopilot = member && member.role === PROJECT_MEMBER_ROLE.COPILOT;
+      const isCustomer = member && member.role === PROJECT_MEMBER_ROLE.CUSTOMER;
       // pick the report based on its name
       let result = {};
       switch (reportName) {
         case 'summary':
           result = await lookApi.findProjectRegSubmissions(projectId);
           break;
         case 'projectBudget':
-          result = await lookApi.findProjectBudget(projectId, isManager, isAdmin);
+          result = await lookApi.findProjectBudget(projectId, { isManager, isAdmin, isCopilot, isCustomer });
           break;
         default:
           return res.status(404).send('Report not found');