Merge pull request #249 from topcoder-platform/feature/PhaseEventPermissions

Limit draft phase update events to topcoder project members

Author: vikasrohit

src/events/busApi.js

@@ -4,6 +4,7 @@ import { EVENT, BUS_API_EVENT, PROJECT_STATUS, PROJECT_PHASE_STATUS, PROJECT_MEM
   from '../constants';
 import { createEvent } from '../services/busApi';
 import models from '../models';
+import getTopcoderProjectMembers from '../util';
 
 /**
  * Map of project status and event name sent to bus api
@@ -364,6 +365,8 @@ module.exports = (app, logger) => {
           projectUrl: connectProjectUrl(projectId),
           userId: req.authUser.userId,
           initiatorUserId: req.authUser.userId,
+          allowedUsers: created.status === PROJECT_PHASE_STATUS.DRAFT ?
+            getTopcoderProjectMembers(project.members) : null,
         }, logger);
         return sendPlanReadyEventIfNeeded(req, project, created);
       }).catch(err => null);    // eslint-disable-line no-unused-vars
@@ -388,6 +391,8 @@ module.exports = (app, logger) => {
           projectUrl: connectProjectUrl(projectId),
           userId: req.authUser.userId,
           initiatorUserId: req.authUser.userId,
+          allowedUsers: deleted.status === PROJECT_PHASE_STATUS.DRAFT ?
+            getTopcoderProjectMembers(project.members) : null,
         }, logger);
       }).catch(err => null);    // eslint-disable-line no-unused-vars
   });
@@ -439,6 +444,8 @@ module.exports = (app, logger) => {
               projectName: project.name,
               userId: req.authUser.userId,
               initiatorUserId: req.authUser.userId,
+              allowedUsers: updated.status === PROJECT_PHASE_STATUS.DRAFT ?
+                getTopcoderProjectMembers(project.members) : null,
             }, logger));
             events.forEach((event) => { eventsMap[event] = true; });
           }
@@ -484,6 +491,8 @@ module.exports = (app, logger) => {
             projectUrl: connectProjectUrl(projectId),
             userId: req.authUser.userId,
             initiatorUserId: req.authUser.userId,
+            allowedUsers: updated.status === PROJECT_PHASE_STATUS.DRAFT ?
+              getTopcoderProjectMembers(project.members) : null,
           }, logger);
         }
       }).catch(err => null);    // eslint-disable-line no-unused-vars

src/util.js

@@ -18,7 +18,7 @@ import elasticsearch from 'elasticsearch';
 import Promise from 'bluebird';
 // import AWS from 'aws-sdk';
 
-import { ADMIN_ROLES, TOKEN_SCOPES, EVENT } from './constants';
+import { ADMIN_ROLES, TOKEN_SCOPES, EVENT, PROJECT_MEMBER_ROLE } from './constants';
 
 const exec = require('child_process').exec;
 const models = require('./models').default;
@@ -474,6 +474,13 @@ _.assignIn(util, {
       });
     });
   },
+
+  /**
+   * Filter only members of topcoder team
+   * @param {Array}  members        project members
+   * @return {Array} tpcoder project members
+   */
+  getTopcoderProjectMembers: members => _(members).filter(m => m.role !== PROJECT_MEMBER_ROLE.CUSTOMER),
 });
 
 export default util;