feat: return products if requested even if phases are not listed in fields

Author: maxceem

src/routes/projects/get.spec.js

@@ -610,27 +610,6 @@ describe('GET Project', () => {
           }
         });
       });
-
-      it('should not return "phases.products.name" field, when it\'s defined in "fields" query param but "phases" is not defined', (done) => {
-        request(server)
-
-        .get(`/v5/projects/${project1.id}?fields=id,phases.products.name`)
-        .set({
-          Authorization: `Bearer ${testUtil.jwts.admin}`,
-        })
-        .expect('Content-Type', /json/)
-        .expect(200)
-        .end((err, res) => {
-          if (err) {
-            done(err);
-          } else {
-            const resJson = res.body;
-            should.exist(resJson);
-            resJson.should.not.have.property('phases');
-            done();
-          }
-        });
-      });
     });
   });
 });

src/routes/projects/list.spec.js

@@ -1244,27 +1244,6 @@ describe('LIST Project', () => {
           }
         });
       });
-
-      it('should not return "phases.products.name" field, when it\'s defined in "fields" query param but "phases" is not defined', (done) => {
-        request(server)
-        .get('/v5/projects/?fields=phases.products.name')
-        .set({
-          Authorization: `Bearer ${testUtil.jwts.admin}`,
-        })
-        .expect('Content-Type', /json/)
-        .expect(200)
-        .end((err, res) => {
-          if (err) {
-            done(err);
-          } else {
-            const resJson = res.body;
-            should.exist(resJson);
-            const project = _.find(resJson, p => p.id === 1);
-            project.should.not.have.property('phases');
-            done();
-          }
-        });
-      });
     });
   });
 });

src/util.js

@@ -256,12 +256,7 @@ _.assignIn(util, {
       }
 
       if (allowedFields.project_phases_products) {
-        if (fields.project_phases.length > 0) {
-          parseSubFields('project_phases_products', 'phases.products');
-        } else {
-          // if donot have 'phases', so hide 'phases.products'
-          fields.project_phases_products = [];
-        }
+        parseSubFields('project_phases_products', 'phases.products');
       }
     }
     return fields;