Merge pull request #52 from topcoder-platform/lock-deletion

lock deletion of resources after the challenge is completed

Author: rootelement

app-constants.js

@@ -9,6 +9,11 @@ const UserRoles = {
   User: 'Topcoder User'
 }
 
+const ChallengeStatuses = {
+  Completed: 'Completed'
+}
+
 module.exports = {
-  UserRoles
+  UserRoles,
+  ChallengeStatuses
 }

src/services/ResourceService.js

@@ -12,6 +12,7 @@ const helper = require('../common/helper')
 const logger = require('../common/logger')
 const errors = require('../common/errors')
 const ResourceRolePhaseDependencyService = require('./ResourceRolePhaseDependencyService')
+const constants = require('../../app-constants')
 
 const payloadFields = ['id', 'challengeId', 'memberId', 'memberHandle', 'roleId', 'created', 'createdBy', 'updated', 'updatedBy', 'legacyId']
 
@@ -237,6 +238,10 @@ async function init (currentUser, challengeId, resource, isCreated) {
   const challengeRes = await helper.getRequest(`${config.CHALLENGE_API_URL}/${challengeId}`)
   const challenge = challengeRes.body
 
+  if (_.get(challenge, 'status') === constants.ChallengeStatuses.Completed && !isCreated) {
+    throw new errors.BadRequestError('Cannot delete resources of a completed challenge!')
+  }
+
   // Prevent from creating more than 1 submitter resources on tasks
   if (_.get(challenge, 'task.isTask', false) && isCreated && resource.roleId === config.SUBMITTER_RESOURCE_ROLE_ID) {
     const existing = await getResources(currentUser, challengeId, config.SUBMITTER_RESOURCE_ROLE_ID, 1, 1)