Updating the getResources to be better at catching legacy IDs and not flooding the logs with output

Author: rootelement

package-lock.json

@@ -48,6 +48,7 @@
     "tc-bus-api-wrapper": "topcoder-platform/tc-bus-api-wrapper.git",
     "tc-core-library-js": "appirio-tech/tc-core-library-js.git#v2.6.4",
     "uuid": "^3.3.2",
+    "uuidv4": "^6.2.3",
     "winston": "^3.2.1",
     "xss": "^1.0.7",
     "yamljs": "^0.3.0"

package.json

@@ -6,7 +6,7 @@ const _ = require('lodash')
 const config = require('config')
 const Joi = require('joi')
 const uuid = require('uuid/v4')
-// const { validate: uuidValidate } = require('uuid')
+const uuidV4 = require('uuidv4')
 const moment = require('moment')
 const helper = require('../common/helper')
 const logger = require('../common/logger')
@@ -45,11 +45,15 @@ async function checkAccess (currentUser, resources) {
  * @returns {Array} the search result
  */
 async function getResources (currentUser, challengeId, roleId, page, perPage) {
-  // if (!uuidValidate(challengeId)) {
-  //   throw new errors.BadRequestError(`Challenge ID ${challengeId} must be a valid UUID`)
-  // }
-  // Verify that the challenge exists
-  await helper.getRequest(`${config.CHALLENGE_API_URL}/${challengeId}`)
+  if (!uuidV4.isUuid(challengeId)) {
+    throw new errors.BadRequestError(`Challenge ID ${challengeId} must be a valid v5 Challenge Id (UUID)`)
+  }
+  try {
+    // Verify that the challenge exists
+    await helper.getRequest(`${config.CHALLENGE_API_URL}/${challengeId}`)
+  } catch (e) {
+    throw new errors.NotFoundError(`Challenge ID ${challengeId} not found`)
+  }
 
   const boolQuery = []
   const mustQuery = []