Fix how we determine if a user has already submitted before adding them as a reviewer

Author: jmgasper

src/common/helper.js

@@ -357,7 +357,7 @@ async function validateDuplicate (modelName, queryParams, errorMessage) {
  */
 async function getRequest (url, query) {
   const m2mToken = await m2m.getMachineToken(config.AUTH0_CLIENT_ID, config.AUTH0_CLIENT_SECRET)
-
+  logger.debug(`GET ${url} with query ${JSON.stringify(query)}`);
   return request
     .get(url)
     .set('Authorization', `Bearer ${m2mToken}`)

src/services/ResourceService.js

@@ -295,7 +295,8 @@ async function init (currentUser, challengeId, resource, isCreated) {
   if (isCreated && (resource.roleId === config.REVIEWER_RESOURCE_ROLE_ID || resource.roleId === config.ITERATIVE_REVIEWER_RESOURCE_ROLE_ID)) {
     const submissionsRes = await helper.getRequest(`${config.SUBMISSIONS_API_URL}`, { challengeId: challengeId, perPage: 100, memberId: memberId })
     const submissions = submissionsRes.body
-    if (submissions.length !== 0) {
+    logger.debug(`Submissions made by member ${memberId} in challenge ${challengeId}: ${JSON.stringify(submissions)}`)
+    if (submissions.meta.totalCount !== 0) {
       throw new errors.ConflictError(`The member has already submitted to the challenge and cannot have a Reviewer or Iterative Reviewer role`)
     }
   }