Add member email for copilots / admins when getting resources, used in the review UI

Author: jmgasper

src/services/ResourceService.js

@@ -16,6 +16,24 @@ const prisma = require('../common/prisma').getClient()
 
 const payloadFields = ['id', 'challengeId', 'memberId', 'memberHandle', 'roleId', 'created', 'createdBy', 'updated', 'updatedBy']
 
+let copilotResourceRoleIdsCache
+
+async function getCopilotResourceRoleIds () {
+  if (copilotResourceRoleIdsCache) {
+    return copilotResourceRoleIdsCache
+  }
+  const roles = await prisma.resourceRole.findMany({
+    where: {
+      nameLower: 'copilot'
+    },
+    select: {
+      id: true
+    }
+  })
+  copilotResourceRoleIdsCache = roles.map(role => role.id)
+  return copilotResourceRoleIdsCache
+}
+
 /**
  * Check whether the user can access resources
  * @param {Array} resources resources of current user for specified challenge id
@@ -74,9 +92,13 @@ async function getResources (currentUser, challengeId, roleId, memberId, memberH
   const prismaFilter = { where: { AND: [] } }
 
   let hasFullAccess
+  let userHasCopilotRole = false
 
   // Check if the user has a resource with full access on the challenge
-  if (currentUser && !currentUser.isMachine && !helper.hasAdminRole(currentUser)) {
+  const isMachineUser = !!(currentUser && currentUser.isMachine)
+  const isAdminUser = !!(currentUser && helper.hasAdminRole(currentUser))
+
+  if (currentUser && !isMachineUser && !isAdminUser) {
     if (challengeId) {
       const resources = await prisma.resource.findMany({
         where: {
@@ -92,6 +114,10 @@ async function getResources (currentUser, challengeId, roleId, memberId, memberH
       } catch (e) {
         hasFullAccess = false
       }
+      if (!userHasCopilotRole) {
+        const copilotRoleIds = await getCopilotResourceRoleIds()
+        userHasCopilotRole = resources.some(resource => copilotRoleIds.includes(resource.roleId))
+      }
     }
     if (memberId && _.toString(memberId) !== _.toString(currentUser.userId)) {
       throw new errors.ForbiddenError('You are not allowed to perform this operation!')
@@ -110,7 +136,7 @@ async function getResources (currentUser, challengeId, roleId, memberId, memberH
   if (!currentUser) {
     // if the user is not logged in, only return resources with submitter role ID
     prismaFilter.where.AND.push({ roleId: config.SUBMITTER_RESOURCE_ROLE_ID })
-  } else if (!currentUser.isMachine && !helper.hasAdminRole(currentUser) && !hasFullAccess) {
+  } else if (!isMachineUser && !isAdminUser && !hasFullAccess) {
     // if not admin, and not machine, only return submitters + all my roles
     prismaFilter.where.AND.push({
       OR: [
@@ -151,6 +177,8 @@ async function getResources (currentUser, challengeId, roleId, memberId, memberH
 
   let memberObjects = await helper.getMemberInfoByIdList(memberIds)
   logger.info(`Retrieved member objects: ${JSON.stringify(memberObjects)}`)
+
+  const shouldExposeMemberEmail = Boolean(challengeId) && (isMachineUser || isAdminUser || userHasCopilotRole)
   const completeResources = []
   for (const resource of resources) {
     const memberInfo = _.find(memberObjects, (o) => _.toNumber('' + o.userId) === _.toNumber(resource.memberId))
@@ -160,6 +188,9 @@ async function getResources (currentUser, challengeId, roleId, memberId, memberH
         rating: memberInfo.maxRating ? memberInfo.maxRating.rating : undefined,
         memberHandle: memberInfo.handle
       }
+      if (shouldExposeMemberEmail && memberInfo.email) {
+        completeResource.memberEmail = memberInfo.email
+      }
       completeResources.push(completeResource)
     } else {
       completeResources.push(resource)

test/unit/getResources.test.js

@@ -63,6 +63,8 @@ module.exports = describe('Get resources', () => {
     should.equal(result.total, 5)
     for (const record of result.data) {
       await assertResource(record.id, record)
+      should.exist(record.memberEmail)
+      record.memberEmail.should.be.String()
     }
     // user phead should have two resources
     should.equal(hasCopilotRole, true)
@@ -76,6 +78,8 @@ module.exports = describe('Get resources', () => {
     should.equal(result.total, 5)
     for (const record of result.data) {
       await assertResource(record.id, record)
+      should.exist(record.memberEmail)
+      record.memberEmail.should.be.String()
     }
     // user phead should have two resources
     should.equal(hasCopilotRole, true)
@@ -86,6 +90,7 @@ module.exports = describe('Get resources', () => {
     const result = await service.getResources(user.diazz, challengeId)
     should.equal(result.total, 1)
     should.equal(result.data[0].memberHandle, 'diazz')
+    should.not.exist(result.data[0].memberEmail)
   })
 
   it('get resources using m2m token', async () => {
@@ -95,6 +100,8 @@ module.exports = describe('Get resources', () => {
     should.equal(result.total, 5)
     for (const record of result.data) {
       await assertResource(record.id, record)
+      should.exist(record.memberEmail)
+      record.memberEmail.should.be.String()
     }
     // user phead should have two resources
     should.equal(hasCopilotRole, true)
@@ -108,6 +115,8 @@ module.exports = describe('Get resources', () => {
     should.equal(result.total, 1)
     for (const record of result.data) {
       await assertResource(record.id, record)
+      should.exist(record.memberEmail)
+      record.memberEmail.should.be.String()
     }
     // user phead should have copilot role
     should.equal(hasCopilotRole, true)