Skip to content

Commit 1a332b8

Browse files
committed
Removed DB call to get existingRole for error message
1 parent c699a78 commit 1a332b8

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/services/ResourceService.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,10 +353,8 @@ async function init (currentUser, challengeId, resource, isCreated) {
353353
const restrictedRoleIds = await getRestrictedRoleIds()
354354
const existingRestrictedRole = _.find(userResources, r => restrictedRoleIds.includes(r.roleId))
355355
if (existingRestrictedRole) {
356-
// Get the role name for better error message
357-
const existingRole = await getResourceRole(existingRestrictedRole.roleId, false)
358356
throw new errors.BadRequestError(
359-
`User ${handle} is already assigned a ${existingRole.name} role and cannot be registered as a submitter.`
357+
`User ${handle} is already assigned a restricted role (Manager, Copilot, Reviewer, Iterative Reviewer, Screener, Checkpoint Screener, Checkpoint Reviewer, or Approver) and cannot be registered as a submitter.`
360358
)
361359
}
362360
}

0 commit comments

Comments
 (0)