Skip to content

Topgear Iterative Reviewer / submission list fix #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

Topgear Iterative Reviewer / submission list fix #1300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/apps/review/src/lib/components/ChallengeDetailsContent/ChallengeDetailsContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { ActionLoading } from '~/apps/admin/src/lib'
import { ChallengeDetailContext } from '../../contexts'
import {
BackendSubmission,
ChallengeInfo,
ChallengeDetailContextModel,
MappingReviewAppeal,
Screening,
SubmissionInfo,
Expand Down Expand Up @@ -120,6 +120,7 @@ const buildScreeningRows = ({

interface SubmissionTabParams {
selectedTabNormalized: string
allowTopgearSubmissionList: boolean
submissions: BackendSubmission[]
screeningRows: Screening[]
screeningMinimumPassingScore: number | null | undefined
Expand All @@ -131,6 +132,7 @@ interface SubmissionTabParams {

const renderSubmissionTab = ({
selectedTabNormalized,
allowTopgearSubmissionList,
submissions,
screeningRows,
screeningMinimumPassingScore,
Expand All @@ -149,7 +151,7 @@ const renderSubmissionTab = ({
submission => normalizeType(submission.type) === 'contestsubmission',
)
: submissions
const canShowSubmissionList = !isTopgearSubmissionTab
const canShowSubmissionList = (allowTopgearSubmissionList || !isTopgearSubmissionTab)
Copy link

@github-actions github-actions bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The logic for canShowSubmissionList has been modified to include allowTopgearSubmissionList. Ensure that this change aligns with the intended business logic, as it alters the conditions under which the submission list is displayed.

&& selectedTabNormalized !== 'screening'
&& visibleSubmissions.length > 0

Expand Down Expand Up @@ -178,8 +180,23 @@ const renderSubmissionTab = ({
}

export const ChallengeDetailsContent: FC<Props> = (props: Props) => {
const { challengeInfo }: { challengeInfo?: ChallengeInfo } = useContext(ChallengeDetailContext)
const {
challengeInfo,
myResources,
}: ChallengeDetailContextModel = useContext(ChallengeDetailContext)
const { actionChallengeRole }: useRoleProps = useRole()
const hasIterativeReviewerRole = useMemo(
() => myResources.some(
resource => resource.roleName
?.toLowerCase()
.includes('iterative reviewer'),
),
[myResources],
)
const allowTopgearSubmissionList = useMemo(
Copy link

@github-actions github-actions bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ performance]
The use of useMemo for allowTopgearSubmissionList is appropriate for performance optimization, but ensure that the dependencies [actionChallengeRole, hasIterativeReviewerRole] are exhaustive and correctly capture all factors influencing this value.

() => actionChallengeRole !== SUBMITTER || hasIterativeReviewerRole,
[actionChallengeRole, hasIterativeReviewerRole],
)
const { currentMemberId }: UseSubmissionDownloadAccessResult = useSubmissionDownloadAccess()
const {
isLoading: isDownloadingSubmission,
Expand Down Expand Up @@ -364,6 +381,7 @@ export const ChallengeDetailsContent: FC<Props> = (props: Props) => {

if (SUBMISSION_TAB_KEYS.has(selectedTabNormalized)) {
return renderSubmissionTab({
allowTopgearSubmissionList,
downloadSubmission: handleSubmissionDownload,
isActiveChallenge: props.isActiveChallenge,
isDownloadingSubmission,
Expand Down