Merge pull request #835 from topcoder-platform/issue-834

Error in console when going to the next page from skills page

Author: jmgasper

src/libs/core/lib/profile/profile-context/profile.context-provider.tsx

@@ -1,4 +1,4 @@
-import { Dispatch, FC, ReactNode, SetStateAction, useEffect, useState } from 'react'
+import { Dispatch, FC, ReactNode, SetStateAction, useEffect, useRef, useState } from 'react'
 
 import { userUpdatePasswordAsync } from '../../auth'
 import { ChangePasswordRequest } from '../change-password-request.model'
@@ -18,13 +18,21 @@ export const ProfileProvider: FC<ProfileProviderProps> = (props: ProfileProvider
     const [profileContextData, setProfileContextData]:
         [ProfileContextData, Dispatch<SetStateAction<ProfileContextData>>]
         = useState<ProfileContextData>(defaultProfileContextData)
+    const isFetchingProfileRef = useRef<boolean>(false)
 
     function changePassword(userId: number, request: ChangePasswordRequest): Promise<void> {
         return userUpdatePasswordAsync(userId, request.password, request.newPassword)
     }
 
     async function getAndSetProfileAsync(): Promise<void> {
-        const profile: UserProfile | undefined = await profileGetLoggedInAsync()
+        isFetchingProfileRef.current = true
+        let profile: UserProfile | undefined
+        try {
+            profile = await profileGetLoggedInAsync()
+        } catch (error) {
+        }
+
+        isFetchingProfileRef.current = false
         const contextData: ProfileContextData = {
             changePassword,
             initialized: true,
@@ -67,7 +75,7 @@ export const ProfileProvider: FC<ProfileProviderProps> = (props: ProfileProvider
     useEffect(() => {
 
         // if our profile is already initialized, no need to continue
-        if (profileContextData.initialized) {
+        if (profileContextData.initialized || isFetchingProfileRef.current) {
             return
         }
 

src/libs/shared/lib/services/emsi-skills/emsi-skills.service.ts

@@ -4,6 +4,10 @@ import { xhrGetAsync, xhrPostAsync, xhrPutAsync } from '~/libs/core'
 import { EmsiSkill, Skill } from './skill.model'
 
 export async function autoCompleteSkills(queryTerm: string): Promise<Skill[]> {
+    if (!queryTerm) {
+        return Promise.resolve([])
+    }
+
     return xhrGetAsync(`${EnvironmentConfig.API.V5}/emsi-skills/skills/auto-complete?term=${queryTerm}`)
 }