Better encoding for query parameter to auto-complete skills

jmgasper · jmgasper · commit f3dfdb8cf7fb · 2023-09-14T13:54:11.000+10:00
TAL-76
diff --git a/src/libs/shared/lib/services/emsi-skills/emsi-skills.service.ts b/src/libs/shared/lib/services/emsi-skills/emsi-skills.service.ts
@@ -10,7 +10,8 @@ export async function autoCompleteSkills(queryTerm: string): Promise<Skill[]> {
         return Promise.resolve([])
     }
 
-    return xhrGetAsync(`${EnvironmentConfig.API.V5}/emsi-skills/skills/auto-complete?term=${queryTerm}`)
+    const encodedQuery = encodeURIComponent(queryTerm)
+    return xhrGetAsync(`${EnvironmentConfig.API.V5}/emsi-skills/skills/auto-complete?term=${encodedQuery}`)
 }
 
 export type FetchMemberSkillsConfig = {

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,8 @@ export async function autoCompleteSkills(queryTerm: string): Promise<Skill[]> {`
`10`	`10`	`return Promise.resolve([])`
`11`	`11`	`}`
`12`	`12`
`13`		- return xhrGetAsync(`${EnvironmentConfig.API.V5}/emsi-skills/skills/auto-complete?term=${queryTerm}`)
	`13`	`+ const encodedQuery = encodeURIComponent(queryTerm)`
	`14`	+ return xhrGetAsync(`${EnvironmentConfig.API.V5}/emsi-skills/skills/auto-complete?term=${encodedQuery}`)
`14`	`15`	`}`
`15`	`16`
`16`	`17`	`export type FetchMemberSkillsConfig = {`