Skip to content

Commit ec25968

Browse files
committed
Simplify routing system for review app
1 parent 9c25b0c commit ec25968

File tree

16 files changed

+240
-297
lines changed

16 files changed

+240
-297
lines changed

src/apps/review/src/config/routes.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ export const activeReviewAssignmentsRouteId = 'active-challenges'
1212
export const openOpportunitiesRouteId = 'open-opportunities'
1313
export const pastReviewAssignmentsRouteId = 'past-challenges'
1414
export const challengeDetailRouteId = ':challengeId'
15-
export const pastChallengeDetailContainerRouteId = 'past-challenge-details'
1615
export const scorecardRouteId = 'scorecard'
16+
export const aiScorecardRouteId = 'ai-scorecard'
1717
export const viewScorecardRouteId = ':scorecardId'

src/apps/review/src/pages/active-review-assignements/ActiveReviewAssigments.tsx

Lines changed: 0 additions & 40 deletions
This file was deleted.

src/apps/review/src/pages/active-review-assignements/ChallengeDetailContainer.tsx

Lines changed: 0 additions & 57 deletions
This file was deleted.
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
import { getRoutesContainer, lazyLoad, LazyLoadedComponent } from '~/libs/core';
2+
3+
import { activeReviewAssignmentsRouteId, challengeDetailRouteId } from '../../config/routes.config';
4+
5+
import { challengeDetailsRoutes } from './challenge-details.routes';
6+
7+
const ActiveReviewsPage: LazyLoadedComponent = lazyLoad(
8+
() => import('./ActiveReviewsPage'),
9+
'ActiveReviewsPage',
10+
)
11+
12+
export const activeReviewChildRoutes = [
13+
{
14+
authRequired: true,
15+
element: <ActiveReviewsPage />,
16+
id: 'active-reviews-page',
17+
route: '',
18+
},
19+
...challengeDetailsRoutes,
20+
];
21+
22+
export const activeReviewRoutes = [
23+
{
24+
children: [ ...activeReviewChildRoutes ],
25+
element: getRoutesContainer(activeReviewChildRoutes),
26+
id: activeReviewAssignmentsRouteId,
27+
route: activeReviewAssignmentsRouteId,
28+
}
29+
]
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
import { getRoutesContainer, lazyLoad, LazyLoadedComponent } from '~/libs/core';
2+
3+
import { challengeDetailRouteId } from '../../config/routes.config';
4+
import { aiScorecardRoutes } from '../ai-scorecards';
5+
6+
const ChallengeDetailContextProvider: LazyLoadedComponent = lazyLoad(
7+
() => import('../../lib/contexts/ChallengeDetailContextProvider'),
8+
'ChallengeDetailContextProvider'
9+
)
10+
const ScorecardDetailsPage: LazyLoadedComponent = lazyLoad(
11+
() => import('./ScorecardDetailsPage'),
12+
'ScorecardDetailsPage',
13+
)
14+
15+
const ChallengeDetailsPage: LazyLoadedComponent = lazyLoad(
16+
() => import('./ChallengeDetailsPage'),
17+
'ChallengeDetailsPage',
18+
)
19+
20+
export const challengeDetailsChildRoutes = [
21+
{
22+
element: <ChallengeDetailsPage />,
23+
id: 'challenge-details-page',
24+
route: 'challenge-details',
25+
},
26+
{
27+
element: <ScorecardDetailsPage />,
28+
id: 'scorecard-details-page',
29+
route: 'review/:reviewId',
30+
},
31+
...aiScorecardRoutes,
32+
]
33+
34+
export const challengeDetailsRoutes = [
35+
{
36+
authRequired: true,
37+
children: challengeDetailsChildRoutes,
38+
element: getRoutesContainer(challengeDetailsChildRoutes, ChallengeDetailContextProvider),
39+
id: challengeDetailRouteId,
40+
route: challengeDetailRouteId,
41+
}
42+
]
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
export * from './active-review.routes'
2+
export * from './challenge-details.routes'
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
import { getRoutesContainer, PlatformRoute, UserRole } from '~/libs/core'
2+
3+
import { aiScorecardRouteId } from '../../config/routes.config'
4+
5+
export const aiScorecardChildRoutes: ReadonlyArray<PlatformRoute> = [
6+
{
7+
authRequired: false,
8+
element: <div>test</div>,
9+
id: 'view-ai-scorecard-page',
10+
route: ':scorecardId',
11+
},
12+
13+
]
14+
15+
// const AiScorecardsContainer = getRoutesContainer(aiScorecardChildRoutes);
16+
17+
export const aiScorecardRoutes: ReadonlyArray<PlatformRoute> = [
18+
{
19+
children: [ ...aiScorecardChildRoutes ],
20+
element: getRoutesContainer(aiScorecardChildRoutes),
21+
id: aiScorecardRouteId,
22+
rolesRequired: [
23+
// UserRole.administrator,
24+
],
25+
route: aiScorecardRouteId,
26+
}
27+
]
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export * from './ai-scorecard.routes'
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export * from './past-review.routes'
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
import { getRoutesContainer, lazyLoad, LazyLoadedComponent } from '~/libs/core';
2+
3+
import { pastReviewAssignmentsRouteId } from '../../config/routes.config';
4+
import { challengeDetailsRoutes } from '../active-review-assignements';
5+
6+
const PastReviewsPage: LazyLoadedComponent = lazyLoad(
7+
() => import('./PastReviewsPage'),
8+
'PastReviewsPage',
9+
)
10+
11+
export const pastReviewChildRoutes = [
12+
{
13+
authRequired: true,
14+
element: <PastReviewsPage />,
15+
id: 'past-reviews-page',
16+
route: '',
17+
},
18+
...challengeDetailsRoutes,
19+
];
20+
21+
export const pastReviewRoutes = [
22+
{
23+
children: pastReviewChildRoutes,
24+
element: getRoutesContainer(pastReviewChildRoutes),
25+
id: pastReviewAssignmentsRouteId,
26+
route: pastReviewAssignmentsRouteId,
27+
}
28+
]

0 commit comments

Comments
 (0)