Skip to content

Commit ebf0f7f

Browse files
authored
Merge pull request #936 from topcoder-platform/feature/standardized-skills
Standardized skills PROD release -> master
2 parents f711889 + 7ffe3bc commit ebf0f7f

File tree

51 files changed

+576
-347
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+576
-347
lines changed

.circleci/config.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,15 +234,13 @@ workflows:
234234
ignore:
235235
- master
236236
- qa
237-
- profiles-app
238237

239238
- build-qa:
240239
context: org-global
241240
filters:
242241
branches:
243242
only:
244243
- qa
245-
- profiles-app
246244

247245
- build-prod:
248246
context: org-global
@@ -261,7 +259,7 @@ workflows:
261259
- dev
262260
- justin_fixes
263261
- talent_search_fixes
264-
- PROD-4398_integrate-userflow-remove-sprig
262+
- feature/standardized-skills
265263

266264
- deployQa:
267265
context: org-global

src/apps/learn/src/lib/components/skill-tags/SkillTags.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { Tooltip } from '~/libs/ui'
55
import { EnvironmentConfig } from '~/config'
66

77
import { SkillLabel } from '..'
8-
import { TCAEMSISkillType } from '../../data-providers'
8+
import { TCASkillType } from '../../data-providers'
99

1010
import styles from './SkillTags.module.scss'
1111

@@ -15,7 +15,7 @@ interface SkillTagsProps {
1515
label?: string
1616
theme?: 'white' | 'gray' | undefined
1717
skills?: Array<string> | null | undefined
18-
emsiSkills?: TCAEMSISkillType[]
18+
emsiSkills?: TCASkillType[]
1919
}
2020

2121
const SkillTags: FC<SkillTagsProps> = (props: SkillTagsProps) => {
@@ -24,15 +24,15 @@ const SkillTags: FC<SkillTagsProps> = (props: SkillTagsProps) => {
2424
const label: string = props.label ?? 'skills taught'
2525
const tcaEMSIEnabled: boolean = EnvironmentConfig.ENABLE_EMSI_SKILLS || false
2626

27-
const skills: string[] | TCAEMSISkillType[] = tcaEMSIEnabled ? (props.emsiSkills || []) : (props.skills || [])
27+
const skills: string[] | TCASkillType[] = tcaEMSIEnabled ? (props.emsiSkills || []) : (props.skills || [])
2828

2929
return (
3030
<div className={styles.skills}>
3131
{label && (
3232
<span className={classNames('body-small', styles.infoText)}>{label}</span>
3333
)}
3434
{skills?.slice(0, expandCount)
35-
.map((skill: string | TCAEMSISkillType) => (
35+
.map((skill: string | TCASkillType) => (
3636
<SkillLabel
3737
skill={skill}
3838
theme={theme}

src/apps/learn/src/lib/components/skill/SkillLabel.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { FC } from 'react'
22

3-
import { TCAEMSISkillType } from '../../data-providers'
3+
import { TCASkillType } from '../../data-providers'
44

55
import styles from './SkillLabel.module.scss'
66

77
interface SkillLabelProps {
8-
skill: string | TCAEMSISkillType
8+
skill: string | TCASkillType
99
theme: 'white' | 'gray' | undefined
1010
}
1111

src/apps/learn/src/lib/data-providers/courses-provider/learn-course.model.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ import { LearnModelBase } from '../../functions'
22
import { CertificationLearnLevel, LearnCertification } from '../all-certifications-provider'
33
import { LearnModule } from '../lesson-provider'
44
import { ResourceProvider } from '../resource-provider-provider'
5-
import { TCAEMSISkillType } from '../tca-certifications-provider/tca-emsi-skill-type'
5+
import { TCASkillType } from '../tca-certifications-provider/tca-skill-type'
66

77
export interface LearnCourse extends LearnModelBase {
88
certificationId: string
99
completionSuggestions: Array<string>
10-
emsiSkills: Array<TCAEMSISkillType>
10+
emsiSkills: Array<TCASkillType>
1111
estimatedCompletionTimeValue: number
1212
estimatedCompletionTimeUnits: string
1313
fccCourseUuid: string

src/apps/learn/src/lib/data-providers/tca-certifications-provider/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ export * from './tca-certification-progress'
1717
export * from './tca-certification-enrollment-base.model'
1818
export * from './tca-certification-validation'
1919
export * from './tca-certification-enrollment'
20-
export * from './tca-emsi-skill-type'
20+
export * from './tca-skill-type'

src/apps/learn/src/lib/data-providers/tca-certifications-provider/tca-certification.model.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { TCACertificationCompletionTimeRange } from './tca-certification-complet
55
import { TCACertificationProvider } from './tca-certification-provider.model'
66
import { TCACertificationProviderBase } from './tca-certification-provider.model-base'
77
import { TCACertificationResource } from './tca-certification-resource.model'
8-
import { TCAEMSISkillType } from './tca-emsi-skill-type'
8+
import { TCASkillType } from './tca-skill-type'
99

1010
export interface TCACertification {
1111
certificationCategory: TCACertificationCategory
@@ -16,7 +16,7 @@ export interface TCACertification {
1616
createdAt: Date
1717
dashedName: string
1818
description: string
19-
emsiSkills: Array<TCAEMSISkillType>
19+
emsiSkills: Array<TCASkillType>
2020
id: number
2121
introText: string
2222
learnerLevel: TCACertificationLearnLevel
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export type TCAEMSISkillType = {
1+
export type TCASkillType = {
22
assessed: boolean
33
confidence: number
44
emsiId: string

src/apps/learn/src/welcome/tc-certifications/cert-card/TCCertCard.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {
1919
TCACertification,
2020
TCACertificationProgress,
2121
TCACertificationProviderBase,
22-
TCAEMSISkillType,
22+
TCASkillType,
2323
} from '../../../lib'
2424

2525
import styles from './TCCertCard.module.scss'
@@ -43,7 +43,7 @@ const TCCertCard: FC<TCCertCardProps> = (props: TCCertCardProps) => {
4343
skills: string[],
4444
providers: Array<TCACertificationProviderBase>,
4545
dashedName: string
46-
emsiSkills: TCAEMSISkillType[]
46+
emsiSkills: TCASkillType[]
4747
} = props.certification
4848

4949
const isEnrolled: boolean = props.progress?.status === 'enrolled'

src/apps/onboarding/src/models/MemberInfo.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { MemberEmsiSkill, MemberMaxRating } from '~/apps/talent-search/src/lib/models'
2-
import { MemberStats } from '~/libs/core'
1+
import { MemberMaxRating } from '~/apps/talent-search/src/lib/models'
2+
import { MemberStats, UserSkill } from '~/libs/core'
33

44
import MemberAddress from './MemberAddress'
55

@@ -13,7 +13,7 @@ export default interface MemberInfo {
1313
email: string
1414
accountAge: number
1515
maxRating: MemberMaxRating
16-
emsiSkills: Array<MemberEmsiSkill>
16+
skills: Array<UserSkill>
1717
stats: Array<MemberStats>
1818
addresses?: MemberAddress[]
1919
country: string

src/apps/onboarding/src/pages/skills/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ export const PageSkillsContent: FC<{
1616
}> = props => {
1717
const navigate: any = useNavigate()
1818
const [loading, setLoading] = useState(false)
19-
const { formInput: emsiFormInput, saveSkills: saveEmsiSkills }: MemberSkillEditor = useMemberSkillEditor()
19+
const editor: MemberSkillEditor = useMemberSkillEditor()
2020

2121
async function saveSkills(): Promise<void> {
2222
setLoading(true)
2323
try {
24-
await saveEmsiSkills()
24+
await editor.saveSkills()
2525
} catch (error) {
2626
}
2727

@@ -46,7 +46,7 @@ export const PageSkillsContent: FC<{
4646
Understanding your skills will allow us to connect you to the right opportunities.
4747
</span>
4848
<div className='mt-16 full-width color-black-80'>
49-
{emsiFormInput}
49+
{editor.formInput}
5050
</div>
5151
</div>
5252
</div>

0 commit comments

Comments
 (0)