Fix PR review comment to make use of classNames function

asadath1395 · asadath1395 · commit cac3a05aa736 · 2022-10-11T21:48:17.000+05:30
diff --git a/src-ts/lib/loading-spinner/LoadingSpinner.tsx b/src-ts/lib/loading-spinner/LoadingSpinner.tsx
@@ -27,7 +27,7 @@ const LoadingSpinner: FC<LoadingSpinnerProps> = ({ hide, className, type = 'Norm
 
     const isOverlay: boolean = type === 'Overlay'
     return (
-        <div className={classNames(styles['loading-spinner'], styles.show, isOverlay ? styles.overlay : '', className)}>
+        <div className={classNames(styles['loading-spinner'], styles.show, {[styles.overlay]: isOverlay}, className)}>
             <PuffLoader color={'#2196f3'} loading={true} size={100} />
         </div>
     )

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ const LoadingSpinner: FC<LoadingSpinnerProps> = ({ hide, className, type = 'Norm`
`27`	`27`
`28`	`28`	`const isOverlay: boolean = type === 'Overlay'`
`29`	`29`	`return (`
`30`		`- <div className={classNames(styles['loading-spinner'], styles.show, isOverlay ? styles.overlay : '', className)}>`
	`30`	`+ <div className={classNames(styles['loading-spinner'], styles.show, {[styles.overlay]: isOverlay}, className)}>`
`31`	`31`	`<PuffLoader color={'#2196f3'} loading={true} size={100} />`
`32`	`32`	`</div>`
`33`	`33`	`)`