Merge branch 'feat/v6' of github.com:topcoder-platform/platform-ui into feat/ai-workflows

Author: vas3a

src/apps/review/src/lib/components/ChallengePhaseInfo/ChallengePhaseInfo.tsx

@@ -14,13 +14,19 @@ import { Link } from 'react-router-dom'
 import _ from 'lodash'
 import classNames from 'classnames'
 
+import { UserRole } from '~/libs/core'
 import { TableMobile } from '~/apps/admin/src/lib/components/common/TableMobile'
 import { IsRemovingType } from '~/apps/admin/src/lib/models'
 import { MobileTableColumn } from '~/apps/admin/src/lib/models/MobileTableColumn.model'
 import { copyTextToClipboard, useWindowSize, WindowSize } from '~/libs/shared'
 import { IconOutline, Table, TableColumn, Tooltip } from '~/libs/ui'
 
-import { ChallengeDetailContextModel, Screening, SubmissionInfo } from '../../models'
+import {
+    ChallengeDetailContextModel,
+    ReviewAppContextModel,
+    Screening,
+    SubmissionInfo,
+} from '../../models'
 import { TableWrapper } from '../TableWrapper'
 import { SubmissionHistoryModal } from '../SubmissionHistoryModal'
 import {
@@ -30,12 +36,14 @@ import {
     partitionSubmissionHistory,
     SubmissionHistoryPartition,
 } from '../../utils'
-import { ChallengeDetailContext } from '../../contexts'
+import { ChallengeDetailContext, ReviewAppContext } from '../../contexts'
 import { useSubmissionDownloadAccess } from '../../hooks'
 import type { UseSubmissionDownloadAccessResult } from '../../hooks/useSubmissionDownloadAccess'
 
 import styles from './TableSubmissionScreening.module.scss'
 
+const VIEW_OWN_SCORECARD_TOOLTIP = 'You can only view scorecards for your own submissions.'
+
 interface Props {
     className?: string
     screenings: Screening[]
@@ -60,6 +68,11 @@ interface BaseColumnsConfig {
     virusScanColumn: TableColumn<Screening>
 }
 
+interface ScreeningColumnConfig {
+    canViewAllScorecards: boolean
+    currentMemberId?: string
+}
+
 interface ActionRenderer {
     key: string
     render: (isLast: boolean) => JSX.Element
@@ -216,11 +229,14 @@ const createBaseColumns = ({
     virusScanColumn,
 ]
 
-const createScreeningColumns = (): TableColumn<Screening>[] => [
+const createScreeningColumns = ({
+    canViewAllScorecards,
+    currentMemberId,
+}: ScreeningColumnConfig): TableColumn<Screening>[] => [
     {
         label: 'Screener',
         propertyName: 'screenerHandle',
-        renderer: (data: Screening) => (data.screener?.id ? (
+        renderer: (data: Screening) => (data.screener?.memberHandle ? (
             <a
                 href={getHandleUrl(data.screener)}
                 target='_blank'
@@ -251,7 +267,36 @@ const createScreeningColumns = (): TableColumn<Screening>[] => [
     {
         label: 'Screening Score',
         propertyName: 'score',
-        type: 'text',
+        renderer: (data: Screening) => {
+            const scoreValue = data.score ?? '-'
+
+            if (!data.reviewId) {
+                return <span>{scoreValue}</span>
+            }
+
+            const canViewScorecard = canViewAllScorecards
+                || Boolean(data.memberId && data.memberId === currentMemberId)
+
+            if (!canViewScorecard) {
+                return (
+                    <Tooltip content={VIEW_OWN_SCORECARD_TOOLTIP} triggerOn='click-hover'>
+                        <span className={styles.tooltipTrigger}>
+                            <span className={styles.textBlue}>{scoreValue}</span>
+                        </span>
+                    </Tooltip>
+                )
+            }
+
+            return (
+                <Link
+                    to={`./../review/${data.reviewId}`}
+                    className={styles.textBlue}
+                >
+                    {scoreValue}
+                </Link>
+            )
+        },
+        type: 'element',
     },
     {
         label: 'Screening Result',
@@ -397,14 +442,39 @@ const normalizeCreatedAt = (
 export const TableSubmissionScreening: FC<Props> = (props: Props) => {
     const { width: screenWidth }: WindowSize = useWindowSize()
     const isTablet = useMemo(() => screenWidth <= 984, [screenWidth])
-    const { challengeInfo }: ChallengeDetailContextModel = useContext(
+    const { challengeInfo, myRoles }: ChallengeDetailContextModel = useContext(
         ChallengeDetailContext,
     )
+    const { loginUserInfo }: ReviewAppContextModel = useContext(ReviewAppContext)
     const {
         restrictionMessage,
         isSubmissionDownloadRestrictedForMember,
         getRestrictionMessageForMember,
+        currentMemberId,
     }: UseSubmissionDownloadAccessResult = useSubmissionDownloadAccess()
+
+    const normalisedRoles = useMemo(
+        () => (myRoles ?? []).map(role => role.toLowerCase()),
+        [myRoles],
+    )
+
+    const hasCopilotRole = useMemo(
+        () => normalisedRoles.some(role => role.includes('copilot')),
+        [normalisedRoles],
+    )
+
+    const isAdminUser = useMemo(
+        () => loginUserInfo?.roles?.some(
+            role => typeof role === 'string'
+                && role.toLowerCase() === UserRole.administrator,
+        ) ?? false,
+        [loginUserInfo?.roles],
+    )
+
+    const canViewAllScorecards = useMemo(
+        () => isAdminUser || hasCopilotRole,
+        [isAdminUser, hasCopilotRole],
+    )
     const showScreeningColumns = props.showScreeningColumns ?? true
     const submissionTypes = useMemo(
         () => new Set(
@@ -608,7 +678,13 @@ export const TableSubmissionScreening: FC<Props> = (props: Props) => {
         [handleColumn, submissionColumn, submissionDateColumn, virusScanColumn],
     )
 
-    const screeningColumns = useMemo<TableColumn<Screening>[]>(createScreeningColumns, [])
+    const screeningColumns = useMemo<TableColumn<Screening>[]>(
+        () => createScreeningColumns({
+            canViewAllScorecards,
+            currentMemberId,
+        }),
+        [canViewAllScorecards, currentMemberId],
+    )
 
     const actionColumn = useMemo(
         () => createActionColumn({

src/apps/review/src/lib/components/TableSubmissionScreening/TableSubmissionScreening.tsx

@@ -6,7 +6,7 @@ import { EnvironmentConfig } from '~/config'
 import { getRatingColor, xhrGetAsync } from '~/libs/core'
 import { handleError } from '~/libs/shared'
 
-import { REVIEWER, SUBMITTER } from '../../config/index.config'
+import { DESIGN, REVIEWER, SUBMITTER } from '../../config/index.config'
 import { ChallengeDetailContext, ReviewAppContext } from '../contexts'
 import {
     BackendPhase,
@@ -2161,7 +2161,17 @@ export function useFetchScreeningReview(): useFetchScreeningReviewProps {
             return 0
         }
 
-        const completedReviews = filter(review, item => {
+        const isDesignChallenge = challengeInfo?.track.name === DESIGN
+
+        const filteredReviews = isDesignChallenge
+            ? review
+            : review.filter(item => item.isLatest)
+
+        if (!filteredReviews.length) {
+            return 0
+        }
+
+        const completedReviews = filteredReviews.filter(item => {
             const committed = item.review?.committed
             if (typeof committed === 'boolean') {
                 return committed
@@ -2185,9 +2195,9 @@ export function useFetchScreeningReview(): useFetchScreeningReviewProps {
         })
 
         return Math.round(
-            (completedReviews.length * 100) / review.length,
+            (completedReviews.length * 100) / filteredReviews.length,
         )
-    }, [review])
+    }, [review, challengeInfo])
 
     useEffect(() => () => {
         cancelLoadResourceAppeal()