Skip to content

Commit bd3b304

Browse files
TCA-548 #comment This commit adds README details for each tool #time 15m
1 parent 2f4eb47 commit bd3b304

File tree

4 files changed

+129
-70
lines changed

4 files changed

+129
-70
lines changed

README.md

Lines changed: 113 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,75 @@ All future user interfaces at Topcoder will be implemented here. Pre-existing us
66

77
>**NOTE:** The information in this file describes our coding standards and best practices. All new code should follow these guidelines both when coding new features as well as porting old features. Please take the time to read through this file in detail.
88
9-
# Getting started with local development
9+
- [Source Control & CI/CD](#source-control--cicd)
10+
- [Local Development](#local-development)
11+
- [Application Structure](#application-structure)
12+
- [Coding Practices](#coding-practices)
13+
- [Tools](#tools)
14+
15+
---
16+
17+
# Source Control & CI/CD
1018

11-
- [Local Environment Setup](#local-environment-setup)
1219
- [Deployments](#deployments)
13-
- [Developer Center specific setup](#developer-center-contentful-api-key-and-space-id)
14-
- [Yarn Commands](#yarn-commands)
20+
- [Pull Requests](#pull-requests)
21+
- [Branching](#branching)
22+
- [Commits](#commits)
1523

16-
# Application structure
24+
## Deployments
1725

18-
- [Folder Structure](#folder-structure)
19-
- [Adding a Tool or Util](#adding-a-tool-or-util)
26+
The app uses CircleCI for CI/CD.
2027

21-
# Coding Practices
22-
- [Git](#git)
23-
- [Linting](#linting)
24-
- [Styling](#styling)
25-
- [Icons](#icons)
28+
The `dev` branch is auto-deployed to the dev environment: https://platform-mvp.topcoder-dev.com.
2629

27-
---
30+
The `master` branch is auto-deployed to the production environment: https://platform-ui.topcoder.com.
31+
32+
## Pull Requests
33+
34+
If a Jira ticket if requires any code changes, it should have its own pull request.
35+
36+
PRs should be named as follows:
37+
38+
`[TICKET-###] [Short Description] -> [target-branch-name]`
39+
40+
e.g. `GAME-174 Upload Badge Image Fix -> dev`
41+
42+
PRs should also have a description that includes a link to the Jira ticket and a summary of what the PR is changing.
43+
44+
## Branching
45+
46+
All branches use `dev` as their source. All merges to `dev` should be made via [pull request](#pull-requests) and should be approved by application owner(s).
47+
48+
When working on Jira tickets, a branch should correspond with a single ticket.
49+
50+
When using subtasks, each parent ticket should have its own branch off `dev`, and all subtasks branches should be merged into the parent ticket branch instead of directly to `dev`.
51+
52+
Use the following naming convention for branches in order to link associated Git PRs and branches to the tickets:
53+
54+
`[TICKET-###]_[short-description]`
55+
56+
e.g.: `PROD-1516_work-issue`
57+
58+
## Commits
59+
We use [Smart Commits](https://bigbrassband.com/git-integration-for-jira/documentation/smart-commits.html#bbb-nav-basic-examples) to link comments and time tracking to tickets. You would enter the following as your commit message:
60+
61+
`[TICKET #] #comment <commit message> #time <jira-formatted time>`
62+
63+
e.g.: `PROD-001 #comment adding readme notes #time 45m`
64+
65+
66+
67+
68+
69+
70+
71+
72+
73+
# Local Development
74+
75+
- [Local Environment Setup](#local-environment-setup)
76+
- [Developer Center specific setup](#developer-center-contentful-api-key-and-space-id)
77+
- [Yarn Commands](#yarn-commands)
2878

2979
## Local Environment Setup
3080

@@ -127,28 +177,6 @@ Otherwise, you will need to override the exception each time you load the site.
127177
3. Set the REACT_APP_HOST_ENV=[hostname]
128178
4. Add "start:[hostname]": "sh start-ssl-[hostname].sh" to scripts in package.json
129179

130-
## Deployments
131-
132-
The app uses CircleCI for CI/CD.
133-
134-
The "dev" branch is auto-deployed to the dev environment: https://platform-mvp.topcoder-dev.com.
135-
136-
The "master" branch is auto-deployed to the production environment: https://platform-ui.topcoder.com.
137-
138-
## Developer Center Contentful API Key and Space Id
139-
140-
The app requires two environment variables, which contain the space id and the key used to access contentful and retrieve Thrive Articles.
141-
142-
You should create a file named `.env` in the root folder, and write inside the following lines:
143-
144-
```sh
145-
REACT_APP_CONTENTFUL_EDU_SPACE_ID=<space-id>
146-
REACT_APP_CONTENTFUL_EDU_CDN_API_KEY=<API Key>
147-
```
148-
149-
We should use the same space ID and API Key as Topcoder Thrive, these are for fetching Thrive articles and videos in the landing page.
150-
151-
See the [Dev Center README](/src-ts/tools/dev-center/README.md) for further instructions on setting up the Dev Center.
152180

153181
## yarn Commands
154182

@@ -169,6 +197,15 @@ See the [Dev Center README](/src-ts/tools/dev-center/README.md) for further inst
169197
| `yarn report:coverage`| Generate e2e coverage report in html format |
170198
| `yarn report:coverage:text` | Generate e2e coverage report in text format |
171199

200+
201+
202+
203+
204+
# Application Structure
205+
206+
- [Folder Structure](#folder-structure)
207+
- [Adding a Tool or Util](#adding-a-tool-or-util)
208+
172209
## Folder Structure
173210

174211
The folder structure of the app has the following goals:
@@ -317,44 +354,14 @@ The PlatformRoute model has several useful options:
317354
| `title: string` | The title property is the text that will appear in the Tools or Utils Selectors (this is irrelevant on hidden routes). |
318355
| `rolesRequired: Array<string>` | Requiring roles for a route means that users who do not own the roles will be presented with restricted page when they try to access the route. |
319356

320-
## Git
321-
322-
### Pull Requests
323-
324-
If a Jira ticket if requires any code changes, it should have its own pull request.
325-
326-
PRs should be named as follows:
327-
328-
`[TICKET-###] [Short Description] -> [target-branch-name]`
329-
330-
e.g. `GAME-174 Upload Badge Image Fix -> dev`
331-
332-
PRs should also have a description that includes a link to the Jira ticket and a summary of what the PR is changing.
333-
334-
### Branching
335-
336-
All branches use `dev` as their source. All merges to `dev` should be made via [pull request](#pull-requests) and should be approved by application owner(s).
337-
338-
When working on Jira tickets, a branch should correspond with a single ticket.
339-
340-
When using subtasks, each parent ticket should have its own branch off `dev`, and all subtasks branches should be merged into the parent ticket branch instead of directly to `dev`.
341-
342-
Use the following naming convention for branches in order to link associated Git PRs and branches to the tickets:
343-
344-
`[TICKET-###]_short-description`
345-
346-
e.g.: `PROD-1516_work-issue`
347-
348-
#### Branching strategy
349357

350-
### Commits
351-
We use [Smart Commits](https://bigbrassband.com/git-integration-for-jira/documentation/smart-commits.html#bbb-nav-basic-examples) to link comments and time tracking to tickets. You would enter the following as your commit message:
352-
353-
`[TICKET #] #comment <commit message> #time <jira-formatted time>`
354358

355-
e.g.: `PROD-001 #comment adding readme notes #time 45m`
356359

357360

361+
# Coding Practices
362+
- [Linting](#linting)
363+
- [Styling](#styling)
364+
- [Icons](#icons)
358365
## Linting
359366

360367
### Rules
@@ -567,3 +574,40 @@ e.g.:
567574
```
568575
569576
>**NOTE** - all SVGs require explicit `width` and `height` in the Safari browser in order to be rendered properly, otherwise they'll be rendered to the _default_ size and probably will crop out of view
577+
578+
# Tools
579+
580+
The following summarizes the various [tools](#adding-a-tool-or-util) in the Platform UI.
581+
582+
- [Dev Center](#dev-center)
583+
- [Gamification Admin](#gamification-admin)
584+
- [Learn](#learn)
585+
- [Work](#work)
586+
587+
## Dev Center
588+
589+
A community-led project to document how to work with Topcoder internal applications.
590+
591+
[Dev Center README](./src-ts/tools/dev-center/README.md)
592+
[Dev Center Routes](./src-ts/tools/dev-center/dev-center.routes.tsx)
593+
594+
## Gamification Admin
595+
596+
Application that allows administrators to CRUD badges and de/assign them to specific users.
597+
598+
[Gamification Admin README TBD](./src-ts/tools/gamification-admin/README.md)
599+
[Gamification Admin Routes](./src-ts/tools/gamification-admin/gamification-admin.routes.tsx)
600+
601+
## Learn
602+
603+
Application that serves 3rd-party educational content.
604+
605+
[Learn README](./src-ts/tools/learn/README.md)
606+
[Learn Routes](./src-ts/tools/learn/learn.routes.tsx)
607+
608+
## Work
609+
610+
Application that allows customers to submit/start challenges self-service.
611+
612+
[Work README TBD](./src-ts/tools/work/README.md)
613+
[Work Routes](./src-ts/tools/work/work.routes.tsx)

src-ts/tools/dev-center/README.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
# Dev Center Configuration
22

3-
See the [main app README](/README.md#developer-center-contentful-api-key-and-space-id) for info regarding the environment variables required to run the DEV Center.
3+
The app requires two environment variables, which contain the space id and the key used to access contentful and retrieve Thrive Articles.
4+
5+
You should create a file named `.env` in the root folder, and write inside the following lines:
6+
7+
```sh
8+
REACT_APP_CONTENTFUL_EDU_SPACE_ID=<space-id>
9+
REACT_APP_CONTENTFUL_EDU_CDN_API_KEY=<API Key>
10+
```
11+
12+
We should use the same space ID and API Key as Topcoder Thrive, these are for fetching Thrive articles and videos in the landing page.
413

514
## Landing page
615

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Gamification Admin Tool
2+
3+
TBD

src-ts/tools/work/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Work Tool
2+
3+
TBD

0 commit comments

Comments
 (0)