Merge pull request #1257 from topcoder-platform/PM-2434

PM-2434 Allow Manager to edit scores

Author: himaniraghav3

src/apps/review/src/config/index.config.ts

@@ -65,6 +65,7 @@ export const REVIEWER = 'Reviewer'
 export const SUBMITTER = 'Submitter'
 export const COPILOT = 'Copilot'
 export const ADMIN = 'Admin'
+export const MANAGER = 'Manager'
 
 export const MOCKHANDLE = 'stevenfrog'
 export const REVIEWCOUNT = 3

src/apps/review/src/lib/models/ChallengeRole.type.ts

@@ -1,4 +1,4 @@
 /**
  * Challenge role use for review flow
  */
-export type ChallengeRole = 'Reviewer' | 'Submitter' | 'Copilot' | 'Admin' | ''
+export type ChallengeRole = 'Reviewer' | 'Submitter' | 'Copilot' | 'Admin' | 'Manager' | ''

src/apps/review/src/pages/active-review-assignements/ScorecardDetailsPage/ScorecardDetailsPage.tsx

@@ -31,7 +31,7 @@ import {
 import { BreadCrumbData, ChallengeDetailContextModel } from '../../../lib/models'
 import { SubmissionBarInfo } from '../../../lib/components/SubmissionBarInfo'
 import { ChallengeLinksForAdmin } from '../../../lib/components/ChallengeLinksForAdmin'
-import { ADMIN, COPILOT } from '../../../config/index.config'
+import { ADMIN, COPILOT, MANAGER } from '../../../config/index.config'
 import { useIsEditReview, useIsEditReviewProps } from '../../../lib/hooks/useIsEditReview'
 import { activeReviewAssigmentsRouteId, rootRoute } from '../../../config/routes.config'
 
@@ -319,6 +319,13 @@ export const ScorecardDetailsPage: FC<Props> = (props: Props) => {
         [myChallengeRoles],
     )
 
+    const hasChallengeManagerRole = useMemo(
+        () => myChallengeResources.some(
+            resource => resource.roleName?.toLowerCase() === MANAGER.toLowerCase(),
+        ),
+        [myChallengeResources],
+    )
+
     const hasChallengeCopilotRole = useMemo(
         () => myChallengeResources.some(
             resource => resource.roleName?.toLowerCase() === COPILOT.toLowerCase(),
@@ -331,11 +338,13 @@ export const ScorecardDetailsPage: FC<Props> = (props: Props) => {
             reviewInfo?.committed
             && (hasChallengeAdminRole
                 || hasTopcoderAdminRole
+                || hasChallengeManagerRole
                 || hasChallengeCopilotRole),
         ),
         [
             hasChallengeAdminRole,
             hasChallengeCopilotRole,
+            hasChallengeManagerRole,
             hasTopcoderAdminRole,
             reviewInfo?.committed,
         ],
@@ -381,18 +390,21 @@ export const ScorecardDetailsPage: FC<Props> = (props: Props) => {
                 <>
                     <div className={styles.summary}>
                         <SubmissionBarInfo submission={submissionInfo} />
-                        {actionChallengeRole === ADMIN || actionChallengeRole === COPILOT ? (
-                            <ChallengeLinksForAdmin
-                                isSavingReview={isSavingReview}
-                                saveReviewInfo={saveReviewInfo}
-                                reviewInfo={reviewInfo}
-                                canEditScorecard={canEditScorecard}
-                                isManagerEdit={isManagerEdit}
-                                onToggleManagerEdit={toggleManagerEdit}
-                            />
-                        ) : (
-                            <ChallengeLinks />
-                        )}
+                        {actionChallengeRole === ADMIN
+                         || actionChallengeRole === COPILOT
+                         || actionChallengeRole === MANAGER
+                            ? (
+                                <ChallengeLinksForAdmin
+                                    isSavingReview={isSavingReview}
+                                    saveReviewInfo={saveReviewInfo}
+                                    reviewInfo={reviewInfo}
+                                    canEditScorecard={canEditScorecard}
+                                    isManagerEdit={isManagerEdit}
+                                    onToggleManagerEdit={toggleManagerEdit}
+                                />
+                            ) : (
+                                <ChallengeLinks />
+                            )}
                     </div>
 
                     <ScorecardDetails