Merge pull request #594 from topcoder-platform/TCA-1179_re-enable-circle-ci-linting

TCA-1179 - uncomment linting in circle ci -> dev

Author: vas3a

.circleci/config.yml

@@ -129,13 +129,13 @@ deploy_steps: &deploy_steps
           ./master_deploy.sh -d CFRONT -e $DEPLOY_ENV -c $ENABLE_CACHE
 
 jobs:
-  # lint-dev:
-  #   <<: *defaults
-  #   environment:
-  #     DEPLOY_ENV: "DEV"
-  #     LOGICAL_ENV: "dev"
-  #     APPNAME: "platform-ui-mvp"
-  #   steps: *lint_steps
+  lint-dev:
+    <<: *defaults
+    environment:
+      DEPLOY_ENV: "DEV"
+      LOGICAL_ENV: "dev"
+      APPNAME: "platform-ui-mvp"
+    steps: *lint_steps
 
   # lint-prod:
   #   <<: *defaults
@@ -144,7 +144,7 @@ jobs:
   #     LOGICAL_ENV: "prod"
   #     APPNAME: "platform-ui-mvp"
   #   steps: *lint_steps
-    
+
   build-dev:
     <<: *defaults
     environment:
@@ -160,7 +160,7 @@ jobs:
       LOGICAL_ENV: "prod"
       APPNAME: "platform-ui-mvp"
     steps: *build_steps
-  
+
   test-dev:
     <<: *test_defaults
     environment:
@@ -192,12 +192,12 @@ workflows:
   version: 2
   build:
     jobs:
-      # - lint-dev:
-      #     context : org-global
-      #     filters:
-      #       branches:
-      #         ignore:
-      #           - master
+      - lint-dev:
+          context : org-global
+          filters:
+            branches:
+              ignore:
+                - master
 
       # - lint-prod:
       #     context : org-global
@@ -224,7 +224,7 @@ workflows:
           context : org-global
           requires:
             - build-dev
-          filters: 
+          filters:
             branches:
               only:
                 - dev

src-ts/tools/learn/learn-lib/hiring-manager-view/HiringManagerView.tsx

@@ -6,6 +6,7 @@ import {
     SetStateAction,
     useCallback,
     useLayoutEffect,
+    useMemo,
     useRef,
     useState,
 } from 'react'
@@ -50,6 +51,7 @@ function renderBasicList(items: Array<string> = []): ReactNode {
         </ul>
     )
 }
+
 export interface HiringManagerViewProps {
     certification?: TCACertification
     completedAt?: string
@@ -91,7 +93,9 @@ const HiringManagerView: FC<HiringManagerViewProps> = (props: HiringManagerViewP
     )
     const shareModal: TCAShareCertificateModalData = useTCAShareCertificateModal(ssrCertUrl)
 
-    const renderShareActions: boolean = props.isOwner && !props.isModalView
+    const renderShareActions: boolean = useMemo(() => (
+        !!props.isOwner && !props.isModalView
+    ), [props.isOwner, props.isModalView])
 
     const getCertificateCanvas: () => Promise<HTMLCanvasElement | void>
         = useCertificateCanvas(certificateElRef)