fix: back to challenge redirection

Author: hentrymartin

src/apps/review/src/lib/components/ScorecardDetails/ScorecardDetails.tsx

@@ -418,7 +418,13 @@ export const ScorecardDetails: FC<Props> = (props: Props) => {
             // no-op: navigation should still occur even if revalidation fails
         }
 
-        navigate(-1, {
+        const pastPrefix = '/past-challenges/'
+        // eslint-disable-next-line no-restricted-globals
+        const idx = location.pathname.indexOf(pastPrefix)
+        const url = idx > -1
+            ? `${rootRoute}/past-challenges/${challengeInfo?.id}/challenge-details`
+            : `${rootRoute}/active-challenges/${challengeInfo?.id}/challenge-details`
+        navigate(url, {
             fallback: './../../../../challenge-details',
         })
     }, [challengeId, mutate, navigate])

src/apps/review/src/pages/active-review-assignements/ScorecardDetailsPage/ScorecardDetailsPage.tsx

@@ -272,6 +272,7 @@ export const ScorecardDetailsPage: FC<Props> = (props: Props) => {
             ?? reviewId,
         [reviewId, reviewInfo?.submissionId, submissionInfo?.id],
     )
+    const containsPastChallenges = location.pathname.indexOf('/past-challenges/')
 
     const breadCrumb = useMemo<BreadCrumbData[]>(() => [
         {
@@ -283,7 +284,9 @@ export const ScorecardDetailsPage: FC<Props> = (props: Props) => {
             fallback: './../../../../challenge-details',
             index: 2,
             label: challengeInfo?.name,
-            path: -1,
+            path: containsPastChallenges > -1
+                ? `${rootRoute}/past-challenges/${challengeInfo?.id}/challenge-details`
+                : `${rootRoute}/active-challenges/${challengeInfo?.id}/challenge-details`,
         },
         {
             index: 3,