Skip to content

Commit a617ee8

Browse files
committed
Update search handler types for talent-serach app
1 parent 040ce2b commit a617ee8

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

src/apps/talent-search/src/lib/utils/search-query.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ import { useSearchParams } from 'react-router-dom'
33

44
import { UserSkill } from '~/libs/core'
55

6-
export const encodeUrlQuerySearch = (skills: UserSkill[]): string => (
6+
type PartialUserSkill = Pick<UserSkill, 'id'|'name'>
7+
8+
export const encodeUrlQuerySearch = (skills: PartialUserSkill[]): string => (
79
skills
810
.map(s => `q=${encodeURIComponent(`${s.name}::${s.id}`)}`)
911
.join('&')
@@ -18,13 +20,13 @@ export const parseUrlQuerySearch = (params: string[]): UserSkill[] => (
1820

1921
export const useUrlQuerySearchParms = (paramName: string): [
2022
UserSkill[],
21-
(s: UserSkill[]) => void
23+
(s: PartialUserSkill[]) => void
2224
] => {
2325
const [params, updateParams] = useSearchParams()
2426

2527
const [skills, setSkills] = useState<UserSkill[]>([])
2628

27-
const handleUpdateSearch = useCallback((newSkills: UserSkill[]) => {
29+
const handleUpdateSearch = useCallback((newSkills: PartialUserSkill[]) => {
2830
const searchParams = encodeUrlQuerySearch(newSkills)
2931
updateParams(`${searchParams}`)
3032
}, [updateParams])

src/apps/talent-search/src/routes/search-page/SearchPage.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ export const SearchPage: FC = () => {
2727
navigate(`${TALENT_SEARCH_PATHS.results}?${searchParams}`)
2828
}
2929

30-
function handleSelectSkillFilter(filter: UserSkill[]): void {
31-
setSkillsFilter(filter)
30+
function handleSelectSkillFilter(filter: Pick<UserSkill, 'id'|'name'>[]): void {
31+
setSkillsFilter(filter as UserSkill[])
3232
searchInputRef.current?.focus()
3333
}
3434

@@ -81,7 +81,7 @@ export const SearchPage: FC = () => {
8181
<SearchInput
8282
autoFocus
8383
skills={skillsFilter}
84-
onChange={setSkillsFilter as any}
84+
onChange={handleSelectSkillFilter}
8585
onSearch={navigateToResults}
8686
inputRef={searchInputRef}
8787
/>

src/apps/talent-search/src/routes/search-results-page/SearchResultsPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ const SearchResultsPage: FC = () => {
4949
<SearchInput
5050
className={styles.searchInput}
5151
skills={skills}
52-
onChange={setSkills as any}
52+
onChange={setSkills}
5353
/>
5454
</ContentLayout>
5555
</div>

0 commit comments

Comments
 (0)