Move name of survey in learn-config, move storage hook in learn-lib

Author: vas3a

src-ts/tools/learn/course-completed/CourseCompletedPage.tsx

@@ -11,7 +11,6 @@ import {
     ProfileContextData,
     surveyTriggerForUser,
     textFormatGetSafeString,
-    useLocalStorage,
 } from '../../../lib'
 import {
     AllCertificationsProviderData,
@@ -23,11 +22,13 @@ import {
     useLearnBreadcrumb,
     UserCertificationProgressProviderData,
     UserCertificationProgressStatus,
+    useShowSurvey,
 } from '../learn-lib'
 import { getCertificatePath, getCoursePath, LEARN_PATHS, rootRoute } from '../learn.routes'
 
 import { ReactComponent as StarsSvg } from './stars.svg'
 import styles from './CourseCompletedPage.module.scss'
+import { LearnConfig } from '../learn-config'
 
 const CourseCompletedPage: FC<{}> = () => {
 
@@ -41,7 +42,7 @@ const CourseCompletedPage: FC<{}> = () => {
     const [showSurvey, setShowSurvey]: [
         string,
         Dispatch<SetStateAction<string>>
-    ] = useLocalStorage<string>('tca-show-survey', '')
+    ] = useShowSurvey()
 
     const {
         course: courseData,
@@ -96,7 +97,7 @@ const CourseCompletedPage: FC<{}> = () => {
 
     useEffect(() => {
       if (ready && showSurvey === certificationParam) {
-        surveyTriggerForUser('TCA First Module Completed', profile?.userId)
+        surveyTriggerForUser(LearnConfig.SURVEY.COMPLETED_FIRST_MODULE, profile?.userId)
         setShowSurvey('')
       }
     }, [ready, showSurvey, certificationParam]);

src-ts/tools/learn/free-code-camp/FreeCodeCamp.tsx

@@ -20,7 +20,6 @@ import {
     ProfileContextData,
     surveyTriggerForUser,
     textFormatGetSafeString,
-    useLocalStorage,
 } from '../../../lib'
 import {
     CoursesProviderData,
@@ -40,13 +39,15 @@ import {
     UserCertificationProgressStatus,
     userCertificationProgressUpdateAsync,
     UserCertificationUpdateProgressActions,
+    useShowSurvey,
 } from '../learn-lib'
 import { getCertificationCompletedPath, getCoursePath, getLessonPathFromModule } from '../learn.routes'
 
 import { FccFrame } from './fcc-frame'
 import { FccSidebar } from './fcc-sidebar'
 import { TitleNav } from './title-nav'
 import styles from './FreeCodeCamp.module.scss'
+import { LearnConfig } from '../learn-config'
 
 const FreeCodeCamp: FC<{}> = () => {
 
@@ -70,7 +71,7 @@ const FreeCodeCamp: FC<{}> = () => {
     const [showSurvey, setShowSurvey]: [
         string,
         Dispatch<SetStateAction<string>>
-    ] = useLocalStorage<string>('tca-show-survey', '')
+    ] = useShowSurvey()
 
     const {
         certificationProgress: certificateProgress,
@@ -455,7 +456,7 @@ const FreeCodeCamp: FC<{}> = () => {
 
     useEffect(() => {
         if (ready && showSurvey === certificationParam) {
-            surveyTriggerForUser('TCA First Module Completed', profile?.userId)
+            surveyTriggerForUser(LearnConfig.SURVEY.COMPLETED_FIRST_MODULE, profile?.userId)
             setShowSurvey('')
         }
     }, [

src-ts/tools/learn/learn-config/learn-config.model.ts

@@ -7,4 +7,7 @@ export interface LearnConfigModel {
         value: string,
     }
     CLIENT: string
+    SURVEY: {
+        COMPLETED_FIRST_MODULE: string
+    }
 }

src-ts/tools/learn/learn-config/learn.default.config.ts

@@ -11,4 +11,7 @@ export const LearnConfigDefault: LearnConfigModel = {
         value: 'certificate-container',
     },
     CLIENT: 'https://fcc.topcoder-dev.com:4431',
+    SURVEY: {
+        COMPLETED_FIRST_MODULE: 'TCA First Module Completed',
+    }
 }

src-ts/tools/learn/learn-lib/index.ts

@@ -7,5 +7,6 @@ export * from './data-providers'
 export * from './learn-breadcrumb-provider'
 export * from './learn-swr'
 export * from './my-course-card'
+export * from './survey'
 export * from './svgs'
 export * from './wave-hero'

src-ts/tools/learn/learn-lib/survey/index.ts

@@ -0,0 +1 @@
+export * from './use-show-survey'

src-ts/tools/learn/learn-lib/survey/use-show-survey.ts

@@ -0,0 +1,9 @@
+import { Dispatch, SetStateAction } from "react"
+import { useLocalStorage } from "../../../../lib"
+
+export const useShowSurvey = (): [
+    string,
+    Dispatch<SetStateAction<string>>
+] => {
+    return useLocalStorage<string>('tca-show-survey', '');
+}