Skip to content

Commit 6a48ed5

Browse files
Merge pull request #328 from topcoder-platform/TCA-438_missing-checkmark
TCA-438 Fix Missing Checkmark in Safari
2 parents b871605 + f6536d4 commit 6a48ed5

File tree

5 files changed

+15
-3
lines changed

5 files changed

+15
-3
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -509,3 +509,5 @@ e.g.:
509509
}
510510
}
511511
```
512+
513+
>**NOTE** - all SVGs require explicit `width` and `height` in the Safari browser in order to be rendered properly, otherwise they'll be rendered to the _default_ size and probably will crop out of view

src-ts/lib/styles/mixins/_icons.mixins.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@
4040
width: $space-mxx;
4141
}
4242

43+
@mixin icon-full {
44+
height: 100%;
45+
width: 100%;
46+
}
47+
4348
@mixin icon-size($size) {
4449
height: $size * 1px;
4550
width: $size * 1px;

src-ts/tools/learn/learn-lib/course-outline/status-icon/StatusIcon.module.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,7 @@
33
.checkmark {
44
@include icon-size(26);
55
flex: 0 0 auto;
6-
}
6+
svg {
7+
@include icon-full;
8+
}
9+
}

src-ts/tools/learn/learn-lib/course-outline/step-icon/StepIcon.module.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
color: $black-20;
77

88
.icon {
9+
910
@include icon-xl;
1011
border-radius: 50%;
1112
flex: 0 0 auto;
@@ -21,6 +22,7 @@
2122
background: $black-40;
2223

2324
> svg {
25+
@include icon-full;
2426
margin: -1 * $border;
2527
}
2628
}
@@ -43,4 +45,4 @@
4345
background: $tc-white;
4446
}
4547
}
46-
}
48+
}

src-ts/tools/learn/learn-lib/course-outline/step-icon/StepIcon.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const StepIcon: FC<StepIconProps> = (props: StepIconProps) => {
2424
return (
2525
<>
2626
{props.label && props.completed && (
27-
<IconSolid.CheckCircleIcon />
27+
<IconSolid.CheckCircleIcon viewBox='2 2 16 16' />
2828
)}
2929

3030
{!props.label && (

0 commit comments

Comments
 (0)