Skip to content

Commit 6945b54

Browse files
authored
Merge pull request #816 from topcoder-platform/profiles-app
Profiles app -> dev
2 parents 3fc2df6 + ec30d0f commit 6945b54

File tree

5 files changed

+24
-8
lines changed

5 files changed

+24
-8
lines changed

src/apps/profiles/src/member-profile/skills/HowSkillsWorkModal/HowSkillsWorkModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const HowSkillsWorkModal: FC<HowSkillsWorkModalProps> = (props: HowSkillsWorkMod
3737
by completing opportunities on the platform
3838
</li>
3939
<li>Topcoder tracks and labels these skills, displaying what skills have been proven</li>
40-
<li>The more opportunities our experts complete the higher they rate for associated skills</li>
40+
<li>The more opportunities you complete the higher you rate for associated skills</li>
4141
</ul>
4242
<p>
4343
You can also self-proclaim skills that have not yet been proven.

src/apps/profiles/src/member-profile/tc-achievements/ChallengeWinsBanner/ChallengeWinsBanner.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ const ChallengeWinsBanner: FC<ChallengeWinsBannerProps> = (props: ChallengeWinsB
161161
!!props.memberStats.DEVELOP?.wins
162162
&& props.memberStats.DEVELOP?.subTracks.map((ms: MemberStats) => (ms.wins ? (
163163
<ChallengeWin
164+
key={ms.name}
164165
typeName={subTrackLabelToHumanName(ms.name)}
165166
onClick={bind(handleChallengeWinModalToggle, this, ms.name)}
166167
winCnt={ms.wins}
@@ -171,6 +172,7 @@ const ChallengeWinsBanner: FC<ChallengeWinsBannerProps> = (props: ChallengeWinsB
171172
!!props.memberStats.DESIGN?.wins
172173
&& props.memberStats.DESIGN?.subTracks.map((ms: MemberStats) => (ms.wins ? (
173174
<ChallengeWin
175+
key={ms.name}
174176
typeName={subTrackLabelToHumanName(ms.name)}
175177
onClick={bind(handleChallengeWinModalToggle, this, ms.name)}
176178
winCnt={ms.wins}

src/apps/profiles/src/member-profile/tc-achievements/MemberTCAchievements.module.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,14 @@
3939
.rolesWrap {
4040
display: flex;
4141
align-items: center;
42+
padding: $sp-4;
43+
background-image: linear-gradient(to right, #652385, #8C384C);
44+
color: $tc-white;
45+
border-radius: 8px;
46+
margin: $sp-4 0;
47+
48+
@include ltelg {
49+
margin-bottom: 0;
50+
}
4251
}
4352
}

src/apps/profiles/src/member-profile/tc-achievements/MemberTCAchievements.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,25 @@ const MemberTCAchievements: FC<MemberTCAchievementsProps> = (props: MemberTCAchi
2929
(badge: UserBadge) => /TCO.*Champion/.test(badge.org_badge.badge_name),
3030
).length || 0, [memberBadges])
3131

32+
const tcoQualifications: number = useMemo(() => memberBadges?.rows.filter(
33+
(badge: UserBadge) => /TCO.*Finalist/.test(badge.org_badge.badge_name),
34+
).length || 0, [memberBadges])
35+
3236
const isCopilot: boolean
3337
= useMemo(() => !!memberStats?.COPILOT, [memberStats])
3438

3539
// function handleOpenTCAchievements(): void {
3640
// console.log('handleOpenTCAchievements')
3741
// }
3842

39-
return memberStats?.wins || tcoWins ? (
43+
return memberStats?.wins || tcoWins || tcoQualifications ? (
4044
<div className={styles.container}>
4145
<p className='body-large-medium'>Achievements @ Topcoder</p>
4246

4347
<div className={styles.achievementsWrap}>
4448
{
45-
tcoWins > 0 && (
46-
<TCOWinsBanner tcoWins={tcoWins} />
49+
(tcoWins > 0 || tcoQualifications > 0) && (
50+
<TCOWinsBanner tcoWins={tcoWins} tcoQualifications={tcoQualifications} />
4751
)
4852
}
4953
{
@@ -59,7 +63,7 @@ const MemberTCAchievements: FC<MemberTCAchievementsProps> = (props: MemberTCAchi
5963
{
6064
isCopilot && (
6165
<div className={styles.rolesWrap}>
62-
<p className='body-main-bold'>Special Roles:&nbsp;</p>
66+
<p className='body-main-medium'>Topcoder Special Roles:&nbsp;</p>
6367
<p>Copilot</p>
6468
</div>
6569
)

src/apps/profiles/src/member-profile/tc-achievements/TCOWinsBanner/TCOWinsBanner.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,26 @@ import styles from './TCOWinsBanner.module.scss'
44

55
interface TCOWinsBannerProps {
66
tcoWins: number
7+
tcoQualifications: number
78
}
89

910
const TCOWinsBanner: FC<TCOWinsBannerProps> = (props: TCOWinsBannerProps) => (
1011
<div className={styles.container}>
1112
<p className='body-large-bold'>Topcoder Open (TCO)</p>
1213
<p className={styles.wins}>
1314
{
14-
props.tcoWins === 1 ? (
15+
props.tcoWins === 1 || props.tcoQualifications === 1 ? (
1516
<></>
1617
) : (
1718
<>
18-
{props.tcoWins}
19+
{props.tcoWins || props.tcoQualifications}
1920
{' '}
2021
<span>times</span>
2122
</>
2223
)
2324
}
2425
</p>
25-
<p className={styles.champText}>Champion</p>
26+
<p className={styles.champText}>{props.tcoWins ? 'Champion' : 'Finalist'}</p>
2627
<p className={styles.text}>
2728
Topcoder Open (TCO) is the ultimate programming tournament,
2829
that earns our winners major prestige in the programming community.

0 commit comments

Comments
 (0)