Skip to content

Commit 14afb1b

Browse files
authored
Merge pull request #704 from topcoder-platform/profiles-app
Profiles app -> dev
2 parents c9daaba + da50d05 commit 14afb1b

File tree

6 files changed

+36
-21
lines changed

6 files changed

+36
-21
lines changed

src/apps/profiles/src/member-profile/about-me/ModifyAboutMeModal/ModifyAboutMeModal.module.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,8 @@
1212

1313
.editForm {
1414
margin-top: $sp-4;
15+
16+
:global(.input-wrapper) {
17+
margin-bottom: $sp-4;
18+
}
1519
}

src/apps/profiles/src/member-profile/education-and-certifications/ModifyEducationModal/ModifyEducationModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ const ModifyEducationModal: FC<ModifyEducationModalProps> = (props: ModifyEducat
258258
disabled={false}
259259
error={formErrors.endDate}
260260
dirty
261-
maxDate={new Date()}
261+
showMonthPicker={false}
262262
showYearPicker
263263
dateFormat='yyyy'
264264
/>

src/apps/profiles/src/member-profile/profile-header/ModifyMemberPhotoModal/ModifyMemberPhotoModal.tsx

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ const ModifyMemberPhotoModal: FC<ModifyMemberPhotoModalProps> = (props: ModifyMe
2121

2222
const fileElRef: MutableRefObject<HTMLDivElement | any> = useRef()
2323

24-
const [fileSizeError, setFileSizeError]: [boolean, Dispatch<SetStateAction<boolean>>]
25-
= useState<boolean>(false)
24+
const [fileSelectError, setFileSelectError]: [string | undefined, Dispatch<SetStateAction<string | undefined>>]
25+
= useState<string | undefined>()
2626

2727
function handleModifyPhotoSave(): void {
2828
const formData: FormData = new FormData()
@@ -53,14 +53,19 @@ const ModifyMemberPhotoModal: FC<ModifyMemberPhotoModalProps> = (props: ModifyMe
5353

5454
if (pickedFile) {
5555
if (pickedFile?.size < 2000000) { // max 2mb limit
56+
if (pickedFile.type !== 'image/png' && pickedFile.type !== 'image/jpeg') {
57+
setFileSelectError('Please select a PNG or JPG image.')
58+
return
59+
}
60+
5661
setFile(pickedFile)
57-
setFileSizeError(false)
62+
setFileSelectError(undefined)
5863
} else {
59-
setFileSizeError(true)
64+
setFileSelectError('Please select an image that is less than 2MB.')
6065
}
6166
} else {
6267
setFile(undefined)
63-
setFileSizeError(false)
68+
setFileSelectError(undefined)
6469
}
6570
}
6671

@@ -105,8 +110,8 @@ const ModifyMemberPhotoModal: FC<ModifyMemberPhotoModalProps> = (props: ModifyMe
105110
onClick={handleFilePickClick}
106111
/>
107112
{
108-
fileSizeError && (
109-
<p>Please select an image that is less than 2MB.</p>
113+
fileSelectError && (
114+
<p>{fileSelectError}</p>
110115
)
111116
}
112117
</form>

src/apps/profiles/src/member-profile/work-expirence/WorkExpirenceCard/WorkExpirenceCard.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ const WorkExpirenceCard: FC<WorkExpirenceCardProps> = (props: WorkExpirenceCardP
2727
</p>
2828
</div>
2929
{
30-
props.work.timePeriodFrom || props.work.timePeriodTo ? (
30+
props.work.timePeriodFrom || props.work.timePeriodTo || props.work.working ? (
3131
<div className={styles.workExpirenceCardHeaderRight}>
3232
<p>
3333
{props.work.timePeriodFrom ? moment(props.work.timePeriodFrom)
3434
.format('MM/YYYY') : ''}
35-
{props.work.timePeriodTo || props.work.currentlyWorking ? ' - ' : ''}
35+
{props.work.timePeriodFrom && (props.work.timePeriodTo || props.work.working) ? ' - ' : ''}
3636
{props.work.timePeriodTo ? moment(props.work.timePeriodTo)
37-
.format('MM/YYYY') : (props.work.currentlyWorking ? 'Present' : '')}
37+
.format('MM/YYYY') : (props.work.working ? 'Present' : '')}
3838
</p>
3939
</div>
4040
) : undefined

src/apps/profiles/src/profiles.routes.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export const profilesRoutes: ReadonlyArray<PlatformRoute> = [
1818
{
1919
children: [
2020
{
21+
authRequired: true,
2122
element: <ProfilesLandingPage />,
2223
id: 'ProfilesLandingPage',
2324
route: '',

src/libs/ui/lib/components/form/form-groups/form-input/input-date-picker/InputDatePicker.tsx

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ interface InputDatePickerProps {
2727
readonly minDate?: Date | null | undefined;
2828
readonly minTime?: Date | undefined;
2929
readonly placeholder?: string
30+
readonly showMonthPicker?: boolean
3031
readonly showYearPicker?: boolean
3132
readonly tabIndex?: number
3233
}
@@ -63,16 +64,20 @@ const InputDatePicker: FC<InputDatePickerProps> = (props: InputDatePickerProps)
6364
<IconOutline.ArrowCircleLeftIcon />
6465
</button>
6566

66-
<select
67-
value={months[getMonth(date)]}
68-
onChange={({ target: { value } }: any) => changeMonth(months.indexOf(value))}
69-
>
70-
{months.map(option => (
71-
<option key={option} value={option}>
72-
{option}
73-
</option>
74-
))}
75-
</select>
67+
{
68+
props.showMonthPicker !== false && (
69+
<select
70+
value={months[getMonth(date)]}
71+
onChange={({ target: { value } }: any) => changeMonth(months.indexOf(value))}
72+
>
73+
{months.map(option => (
74+
<option key={option} value={option}>
75+
{option}
76+
</option>
77+
))}
78+
</select>
79+
)
80+
}
7681

7782
<select
7883
value={getYear(date)}

0 commit comments

Comments
 (0)