Show reopen button for registration phase, if submission or TG submission phase is open

Author: jmgasper

src/apps/review/src/pages/active-review-assignements/ChallengeDetailsPage/ChallengeDetailsPage.tsx

@@ -66,6 +66,11 @@ interface Props {
     className?: string
 }
 
+const normalizePhaseName = (name?: string): string => (name ? name.trim()
+    .toLowerCase() : '')
+const SUBMISSION_PHASE_NAMES = new Set(['submission', 'topgear submission'])
+const REGISTRATION_PHASE_NAME = 'registration'
+
 // Helpers to keep UI hooks simple and under complexity limits
 
 // Compute a Set of this member's reviewer resource IDs (excluding iterative roles)
@@ -1089,23 +1094,41 @@ export const ChallengeDetailsPage: FC<Props> = (props: Props) => {
             return allowed
         }
 
-        challengePhases.forEach(phase => {
-            if (!phase?.isOpen || !phase.predecessor) {
+        const addPhaseIdentifiers = (phase?: BackendPhase): void => {
+            if (!phase) {
                 return
             }
 
-            allowed.add(phase.predecessor)
+            if (phase.id) {
+                allowed.add(phase.id)
+            }
 
-            const predecessorPhase = phaseLookup.get(phase.predecessor)
-            if (predecessorPhase?.id) {
-                allowed.add(predecessorPhase.id)
+            if (phase.phaseId) {
+                allowed.add(phase.phaseId)
             }
+        }
 
-            if (predecessorPhase?.phaseId) {
-                allowed.add(predecessorPhase.phaseId)
+        challengePhases.forEach(phase => {
+            if (!phase?.isOpen || !phase.predecessor) {
+                return
             }
+
+            allowed.add(phase.predecessor)
+            addPhaseIdentifiers(phaseLookup.get(phase.predecessor))
         })
 
+        const hasSubmissionVariantOpen = challengePhases.some(phase => (
+            phase?.isOpen && SUBMISSION_PHASE_NAMES.has(normalizePhaseName(phase.name))
+        ))
+
+        if (hasSubmissionVariantOpen) {
+            challengePhases.forEach(phase => {
+                if (normalizePhaseName(phase?.name) === REGISTRATION_PHASE_NAME) {
+                    addPhaseIdentifiers(phase)
+                }
+            })
+        }
+
         return allowed
     }, [challengePhases, phaseLookup])