Fix error seen in dev

Author: jmgasper

src/api/role/role.service.spec.ts

@@ -390,13 +390,16 @@ describe('RoleService', () => {
       ).rejects.toThrow(NotFoundException);
     });
 
-    it('should throw ConflictException if assignment already exists', async () => {
+    it('should ignore duplicate assignment if already exists', async () => {
       mockPrisma.role.count.mockResolvedValue(1);
       mockPrisma.roleAssignment.create.mockRejectedValue({ code: 'P2002' });
 
       await expect(
         service.assignRoleToSubject(roleId, subjectId, operatorId),
-      ).rejects.toThrow(ConflictException);
+      ).resolves.toBeUndefined();
+      expect(mockLogger.warn).toHaveBeenCalledWith(
+        `Attempt to assign role ${roleId} to subject ${subjectId} which already exists. Ignoring duplicate.`,
+      );
     });
   });
 

src/api/role/role.service.ts

@@ -376,18 +376,15 @@ export class RoleService {
     } catch (error) {
       if (error.code === Constants.prismaUniqueConflictcode) {
         this.logger.warn(
-          `Attempt to assign role ${roleId} to subject ${subjectId} which already exists.`,
+          `Attempt to assign role ${roleId} to subject ${subjectId} which already exists. Ignoring duplicate.`,
         );
-        throw new ConflictException(
-          `Role ${roleId} is already assigned to subject ${subjectId}.`,
-        );
-      } else {
-        this.logger.error(
-          `Failed to assign role ${roleId} to subject ${subjectId}: ${error.message}`,
-          error.stack,
-        );
-        throw error;
+        return;
       }
+      this.logger.error(
+        `Failed to assign role ${roleId} to subject ${subjectId}: ${error.message}`,
+        error.stack,
+      );
+      throw error;
     }
   }