Added sanitizeJob() and apply to all recruit calls

Author: luizrrodrigues

src/server/services/recruitCRM.js

@@ -76,6 +76,18 @@ function notifyKirilAndNick(error) {
   });
 }
 
+/**
+ * Sanitize Job before return
+ * @param {Object} job data from recuitcrm api
+ */
+function sanitizeJob(job) {
+  const sJob = _.pick(job, JOB_FIELDS_RESPONSE);
+  sJob.custom_fields = _.filter(
+    sJob.custom_fields, f => !_.includes(OMIT_CUSTOM_FIELDS, f.field_name),
+  );
+  return sJob;
+}
+
 const updateProfileSchema = Joi.object().keys({
   phone: Joi.string().required(),
   availability: Joi.boolean().required(),
@@ -159,14 +171,7 @@ export default class RecruitCRMService {
       }
       const data = await response.json();
 
-      // Sanitize Data
-      data.data = _.map(data.data, (j) => {
-        const sanitizeJob = _.pick(j, JOB_FIELDS_RESPONSE);
-        sanitizeJob.custom_fields = _.filter(
-          sanitizeJob.custom_fields, f => !_.includes(OMIT_CUSTOM_FIELDS, f.field_name),
-        );
-        return sanitizeJob;
-      });
+      data.data = _.map(data.data, j => sanitizeJob(j));
 
       return res.send(data);
     } catch (err) {
@@ -203,7 +208,7 @@ export default class RecruitCRMService {
         return res.send(error);
       }
       const data = await response.json();
-      return res.send(_.pick(data, JOB_FIELDS_RESPONSE));
+      return res.send(sanitizeJob(data));
     } catch (err) {
       return next(err);
     }
@@ -255,11 +260,11 @@ export default class RecruitCRMService {
               const pageData = await pageDataRsp.json();
               data.data = _.flatten(data.data.concat(pageData.data));
             }
-            const toSend = _.map(data.data, j => _.pick(j, JOB_FIELDS_RESPONSE));
+            const toSend = _.map(data.data, j => sanitizeJob(j));
             return toSend;
           });
       }
-      const toSend = _.map(data.data, j => _.pick(j, JOB_FIELDS_RESPONSE));
+      const toSend = _.map(data.data, j => sanitizeJob(j));
       return toSend;
     } catch (err) {
       return err;
@@ -316,15 +321,15 @@ export default class RecruitCRMService {
               const pageData = await pageDataRsp.json();
               data.data = _.flatten(data.data.concat(pageData.data));
             }
-            const toSend = _.map(data.data, j => _.pick(j, JOB_FIELDS_RESPONSE));
+            const toSend = _.map(data.data, j => sanitizeJob(j));
             gigsCache.set(CACHE_KEY, toSend);
             return res.send(toSend);
           })
           .catch(e => res.send({
             error: e,
           }));
       }
-      const toSend = _.map(data.data, j => _.pick(j, JOB_FIELDS_RESPONSE));
+      const toSend = _.map(data.data, j => sanitizeJob(j));
       gigsCache.set(CACHE_KEY, toSend);
       return res.send(toSend);
     } catch (err) {