Revert "fix: no challenges found"

This reverts commit 847a6fe.

Author: dedywahyudi

src/shared/components/challenge-listing/Listing/index.jsx

@@ -17,7 +17,6 @@ import CardPlaceholder from '../placeholders/ChallengeCard';
 import './style.scss';
 
 // const Filter = challengeUtils.filter;
-const LOADING_MESSAGE = 'Loading Challenges';
 
 function Listing({
   activeBucket,
@@ -259,14 +258,7 @@ function Listing({
         loading
           ? placeholders
           : (!filterState.recommended || activeBucket !== 'openForRegistration') && (
-            <div styleName="no-results">
-              {
-                needLoad ? LOADING_MESSAGE
-                  : (
-                    `${NO_LIVE_CHALLENGES_CONFIG[activeBucket]}`
-                  )
-              }
-            </div>
+            <div styleName="no-results">{ `${NO_LIVE_CHALLENGES_CONFIG[activeBucket]}` }</div>
           )
       }
     </div>

src/shared/containers/challenge-listing/Listing/index.jsx

@@ -66,6 +66,8 @@ export class ListingContainer extends React.Component {
       filter,
     } = this.props;
 
+    const { needLoad } = this.state;
+
     markHeaderMenu();
 
     if (queryBucket !== activeBucket && _.includes(BUCKETS, queryBucket)) {
@@ -105,6 +107,10 @@ export class ListingContainer extends React.Component {
       });
     }
     // }
+
+    if (needLoad) {
+      this.setState({ needLoad: false });
+    }
   }
 
   componentDidUpdate(prevProps) {
@@ -134,7 +140,6 @@ export class ListingContainer extends React.Component {
       getPastChallenges,
       filterState,
     } = this.props;
-    const { needLoad } = this.state;
     const oldUserId = _.get(prevProps, 'auth.user.userId');
     const userId = _.get(this.props, 'auth.user.userId');
     const handle = _.get(auth, 'user.handle');
@@ -259,10 +264,6 @@ export class ListingContainer extends React.Component {
     }
     if (filterChanged(filter, prevProps.filter)) {
       this.reloadChallenges();
-      if (needLoad) {
-        // eslint-disable-next-line react/no-did-update-set-state
-        this.setState({ needLoad: false });
-      }
     }
     setTimeout(() => {
       selectBucketDone();